You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2011/12/25 12:04:35 UTC
RE: svn commit: r1223036 - /subversion/trunk/subversion/libsvn_delta/xdelta.c
> -----Original Message-----
> From: stefan2@apache.org [mailto:stefan2@apache.org]
> Sent: zondag 25 december 2011 1:56
> To: commits@subversion.apache.org
> Subject: svn commit: r1223036 -
> /subversion/trunk/subversion/libsvn_delta/xdelta.c
>
> Author: stefan2
> Date: Sun Dec 25 00:56:28 2011
> New Revision: 1223036
>
> URL: http://svn.apache.org/viewvc?rev=1223036&view=rev
> Log:
> Minor xdelta optimization: find short matches at both end of the delta
> window.
All buildbots are red after this patch.
At least one test FAILED, checking E:\w2k3\tests\tests.log
FAIL: svnrdump_tests.py 10: dump: copy from previous version and modify
FAIL: svnrdump_tests.py 11: load: copy from previous version and modify
FAIL: svnrdump_tests.py 12: dump: modified in place
FAIL: svnrdump_tests.py 13: load: modified in place
FAIL: svnrdump_tests.py 26: dump: copy revprops other than svn:*
FAIL: svnrdump_tests.py 27: load: copy revprops other than svn:*
FAIL: svnrdump_tests.py 28: dump: subdirectory
FAIL: svnrdump_tests.py 29: dump: subdirectory with changes on root
FAIL: svnrdump_tests.py 32: dump: move parent & modify child file in same rev
FAIL: svnrdump_tests.py 33: load: move parent & modify child file in same rev
Summary of test results:
1538 tests PASSED
73 tests SKIPPED
34 tests XFAILED (1 WORK-IN-PROGRESS)
10 tests FAILED
Bert
Re: svn commit: r1223036 - /subversion/trunk/subversion/libsvn_delta/xdelta.c
Posted by Hyrum K Wright <hy...@wandisco.com>.
On Sun, Dec 25, 2011 at 11:57 AM, Stefan Fuhrmann <eq...@web.de> wrote:
> On 25.12.2011 12:04, Bert Huijben wrote:
>>>
>>> -----Original Message-----
>
>
>>> Log:
>>> Minor xdelta optimization: find short matches at both end of the delta
>>> window.
>>
>> All buildbots are red after this patch.
>>
>> At least one test FAILED, checking E:\w2k3\tests\tests.log
>> FAIL: svnrdump_tests.py 10: dump: copy from previous version and modify
>> FAIL: svnrdump_tests.py 11: load: copy from previous version and modify
>> FAIL: svnrdump_tests.py 12: dump: modified in place
>> FAIL: svnrdump_tests.py 13: load: modified in place
>> FAIL: svnrdump_tests.py 26: dump: copy revprops other than svn:*
>> FAIL: svnrdump_tests.py 27: load: copy revprops other than svn:*
>> FAIL: svnrdump_tests.py 28: dump: subdirectory
>> FAIL: svnrdump_tests.py 29: dump: subdirectory with changes on root
>> FAIL: svnrdump_tests.py 32: dump: move parent& modify child file in same
>> rev
>> FAIL: svnrdump_tests.py 33: load: move parent& modify child file in same
>> rev
>
>
> Thanks for noticing! (I thought I had run the tests before committing :/ )
>
> The problem here is that the test compares the actual dump files
> produced by svnrdump with the expected ones stored in the test
> data folder. With my patch, the text delta is now often smaller, i.e.
> different from the expected value. Nevertheless the new diffs seem
> to be correct.
>
> So, I will XFAIL the tests in question and $somebody needs to
> update the reference dump files.
I ran across a similar problem in the svnsync tests while working on
Ev2, and added what I think to be a solution in r1230676. Per Bert's
suggestion, I think we can do the same thing in the svnrdump tests,
and have implemented the same in r1230714.
-Hyrum
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Re: svn commit: r1223036 - /subversion/trunk/subversion/libsvn_delta/xdelta.c
Posted by Stefan Fuhrmann <eq...@web.de>.
On 25.12.2011 12:04, Bert Huijben wrote:
>> -----Original Message-----
>> Log:
>> Minor xdelta optimization: find short matches at both end of the delta
>> window.
> All buildbots are red after this patch.
>
> At least one test FAILED, checking E:\w2k3\tests\tests.log
> FAIL: svnrdump_tests.py 10: dump: copy from previous version and modify
> FAIL: svnrdump_tests.py 11: load: copy from previous version and modify
> FAIL: svnrdump_tests.py 12: dump: modified in place
> FAIL: svnrdump_tests.py 13: load: modified in place
> FAIL: svnrdump_tests.py 26: dump: copy revprops other than svn:*
> FAIL: svnrdump_tests.py 27: load: copy revprops other than svn:*
> FAIL: svnrdump_tests.py 28: dump: subdirectory
> FAIL: svnrdump_tests.py 29: dump: subdirectory with changes on root
> FAIL: svnrdump_tests.py 32: dump: move parent& modify child file in same rev
> FAIL: svnrdump_tests.py 33: load: move parent& modify child file in same rev
Thanks for noticing! (I thought I had run the tests before committing :/ )
The problem here is that the test compares the actual dump files
produced by svnrdump with the expected ones stored in the test
data folder. With my patch, the text delta is now often smaller, i.e.
different from the expected value. Nevertheless the new diffs seem
to be correct.
So, I will XFAIL the tests in question and $somebody needs to
update the reference dump files.
-- Stefan^2.