[GitHub] [flink] carp84 commented on a change in pull request #10930: [FLINK-15368][e2e] Add end-to-end test for controlling RocksDB memory usage

[GitBox <gi...@apache.org>]

carp84 commented on a change in pull request #10930: [FLINK-15368][e2e] Add end-to-end test for controlling RocksDB memory usage
URL: https://github.com/apache/flink/pull/10930#discussion_r369976311
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -171,6 +171,8 @@ run_test "ConnectedComponents iterations with high parallelism end-to-end test"
 
 run_test "Dependency shading of table modules test" "$END_TO_END_DIR/test-scripts/test_table_shaded_dependencies.sh"
 
+run_test "RocksDB memory control end-to-end test" "$END_TO_END_DIR/test-scripts/test_rocksdb_state_memory_control.sh" "skip_check_exceptions"
 
 Review comment:
   Tow comments here:
   1. I guess we take an optimistic policy here that although in theory there's a chance that this test be unstable, we enable it by default?
   2. I believe we also need to add this test into `split_misc.sh` and `split_misc_hadoopfree.sh` under `tools/travis/splits` directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services