You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/01 14:51:32 UTC
[GitHub] [superset] kgabryje opened a new pull request, #21294: fix(explore): Time column label not formatted hen GENERIC_X_AXES enabled
kgabryje opened a new pull request, #21294:
URL: https://github.com/apache/superset/pull/21294
### SUMMARY
When user has `GENERIC_CHART_AXES` enabled and adds a custom label to a time column, the timestamps on the chart's x axis are not formatted.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/187944758-00e26588-f0e0-4881-b1e1-8e861702dd70.png">
After:
<img width="1790" alt="image" src="https://user-images.githubusercontent.com/15073128/187944389-e0fbde6a-aaed-4073-b4d3-42267fc8fb3e.png">
### TESTING INSTRUCTIONS
1. Enable `GENERIC_CHART_AXES`
2. Create a Mixed Chart
3. Set a custom label for a time column and use it as x axis
4. Verify that timestamps on x axis are formatted
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #21294: fix(explore): Time column label not formatted when GENERIC_X_AXES enabled
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #21294:
URL: https://github.com/apache/superset/pull/21294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on pull request #21294: fix(explore): Time column label not formatted when GENERIC_X_AXES enabled
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on PR #21294:
URL: https://github.com/apache/superset/pull/21294#issuecomment-1234484030
> > If we bump into more of these we should perhaps consider refactoring this so we don't have to do these checks all over the place.
>
> Yeah those just keep popping up. I know that recently @diegomedina248 fixed the same issue in other echarts
Yeah, that's right.
It would be good to refactor and remove some duplications there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #21294: fix(explore): Time column label not formatted when GENERIC_X_AXES enabled
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #21294:
URL: https://github.com/apache/superset/pull/21294#issuecomment-1234478378
> If we bump into more of these we should perhaps consider refactoring this so we don't have to do these checks all over the place.
Yeah those just keep popping up. I know that recently @diegomedina248 fixed the same issue with other echarts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21294: fix(explore): Time column label not formatted when GENERIC_X_AXES enabled
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21294:
URL: https://github.com/apache/superset/pull/21294#issuecomment-1234480345
# [Codecov](https://codecov.io/gh/apache/superset/pull/21294?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21294](https://codecov.io/gh/apache/superset/pull/21294?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c05297c) into [master](https://codecov.io/gh/apache/superset/commit/9fd752057eb261b0e5db87636836fd30579ffce6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9fd7520) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c05297c differs from pull request most recent head f67d32d. Consider uploading reports for the commit f67d32d to get more accurate results
```diff
@@ Coverage Diff @@
## master #21294 +/- ##
==========================================
- Coverage 66.42% 66.40% -0.03%
==========================================
Files 1784 1784
Lines 68237 68237
Branches 7263 7264 +1
==========================================
- Hits 45328 45310 -18
- Misses 21040 21058 +18
Partials 1869 1869
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.48% <0.00%> (ø)` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hart-echarts/src/MixedTimeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `91.89% <0.00%> (-5.41%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `86.36% <0.00%> (-2.28%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.29% <0.00%> (-1.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.54% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/21294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.73% <0.00%> (-0.48%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org