You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/17 14:38:03 UTC

[GitHub] dawidwys opened a new pull request #7520: [FLINK-11293][kafka, test] Added timeout to delete topic request.

dawidwys opened a new pull request #7520: [FLINK-11293][kafka, test] Added timeout to delete topic request.
URL: https://github.com/apache/flink/pull/7520
 
 
   
   
   ## What is the purpose of the change
   
   The purpose of this PR is to harden kafka ITCases. It targets probable kafka AdminClient connection issues.
   
   ## Brief change log
   
   Logs from failures show that even though the request never finishes,
   kafka topics are actually deleted. Therefore this PR adds timeout on
   delete request. If the request times out we check if the topic actually
   exists. If not then we continue as if the delete request succeeded.
   
   ## Verifying this change
   
   Current kafka ITCases still pass.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no /** don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services