[GitHub] [incubator-superset] villebro commented on issue #9219: [fix] Adding SIP-15 support for the query context

[GitBox <gi...@apache.org>]

villebro commented on issue #9219: [fix] Adding SIP-15 support for the query context
URL: https://github.com/apache/incubator-superset/pull/9219#issuecomment-592685819
 
 
   Looking at the current signature, I feel comfortable with most of the other parameters, but the `relative_start` and `relative_end` ones definitely belong in `extras`. You might have more context here, but I'm fairly we can move them over to `extras` without breaking anything. If not feel free to merge this as is, I can also address this later, as I'll probably be touching this code in the near future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org