You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Ludger Bünger (JIRA)" <xe...@xml.apache.org> on 2009/06/25 10:25:07 UTC
[jira] Created: (XERCESJ-1380) getData method is duplicated in
CharacterDataImpl and ProcessingInstructionImpl...
getData method is duplicated in CharacterDataImpl and ProcessingInstructionImpl...
----------------------------------------------------------------------------------
Key: XERCESJ-1380
URL: https://issues.apache.org/jira/browse/XERCESJ-1380
Project: Xerces2-J
Issue Type: Improvement
Components: DOM (Level 3 Core)
Reporter: Ludger Bünger
Priority: Trivial
I know, this is really trivial, but I thought I might still file a short report.
The method getData() is duplicated with identical code in CharacterDataImpl and its descendant ProcessingInstructionImpl and thus can be removed from ProcessingInstructionImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] Assigned: (XERCESJ-1380) getData method is duplicated in
CharacterDataImpl and ProcessingInstructionImpl...
Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glavassevich reassigned XERCESJ-1380:
---------------------------------------------
Assignee: Michael Glavassevich
> getData method is duplicated in CharacterDataImpl and ProcessingInstructionImpl...
> ----------------------------------------------------------------------------------
>
> Key: XERCESJ-1380
> URL: https://issues.apache.org/jira/browse/XERCESJ-1380
> Project: Xerces2-J
> Issue Type: Improvement
> Components: DOM (Level 3 Core)
> Reporter: Ludger Bünger
> Assignee: Michael Glavassevich
> Priority: Trivial
> Attachments: patch.txt
>
>
> I know, this is really trivial, but I thought I might still file a short report.
> The method getData() is duplicated with identical code in CharacterDataImpl and its descendant ProcessingInstructionImpl and thus can be removed from ProcessingInstructionImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] Updated: (XERCESJ-1380) getData method is duplicated in
CharacterDataImpl and ProcessingInstructionImpl...
Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glavassevich updated XERCESJ-1380:
------------------------------------------
Affects Version/s: 2.9.1
> getData method is duplicated in CharacterDataImpl and ProcessingInstructionImpl...
> ----------------------------------------------------------------------------------
>
> Key: XERCESJ-1380
> URL: https://issues.apache.org/jira/browse/XERCESJ-1380
> Project: Xerces2-J
> Issue Type: Improvement
> Components: DOM (Level 3 Core)
> Affects Versions: 2.9.1
> Reporter: Ludger Bünger
> Assignee: Michael Glavassevich
> Priority: Trivial
> Attachments: patch.txt
>
>
> I know, this is really trivial, but I thought I might still file a short report.
> The method getData() is duplicated with identical code in CharacterDataImpl and its descendant ProcessingInstructionImpl and thus can be removed from ProcessingInstructionImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] Commented: (XERCESJ-1380) getData method is duplicated in
CharacterDataImpl and ProcessingInstructionImpl...
Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790007#action_12790007 ]
Michael Glavassevich commented on XERCESJ-1380:
-----------------------------------------------
The setData() method in this class is also redundant (identical implementation in CharacterDataImpl) so I'll also be removing it.
> getData method is duplicated in CharacterDataImpl and ProcessingInstructionImpl...
> ----------------------------------------------------------------------------------
>
> Key: XERCESJ-1380
> URL: https://issues.apache.org/jira/browse/XERCESJ-1380
> Project: Xerces2-J
> Issue Type: Improvement
> Components: DOM (Level 3 Core)
> Affects Versions: 2.9.1
> Reporter: Ludger Bünger
> Assignee: Michael Glavassevich
> Priority: Trivial
> Attachments: patch.txt
>
>
> I know, this is really trivial, but I thought I might still file a short report.
> The method getData() is duplicated with identical code in CharacterDataImpl and its descendant ProcessingInstructionImpl and thus can be removed from ProcessingInstructionImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] Resolved: (XERCESJ-1380) getData method is duplicated in
CharacterDataImpl and ProcessingInstructionImpl...
Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glavassevich resolved XERCESJ-1380.
-------------------------------------------
Resolution: Fixed
Fix Version/s: 2.10.0
Thanks Ludger. I've committed you patch and while I was at it also removed setData(). See SVN rev 890194.
> getData method is duplicated in CharacterDataImpl and ProcessingInstructionImpl...
> ----------------------------------------------------------------------------------
>
> Key: XERCESJ-1380
> URL: https://issues.apache.org/jira/browse/XERCESJ-1380
> Project: Xerces2-J
> Issue Type: Improvement
> Components: DOM (Level 3 Core)
> Affects Versions: 2.9.1
> Reporter: Ludger Bünger
> Assignee: Michael Glavassevich
> Priority: Trivial
> Fix For: 2.10.0
>
> Attachments: patch.txt
>
>
> I know, this is really trivial, but I thought I might still file a short report.
> The method getData() is duplicated with identical code in CharacterDataImpl and its descendant ProcessingInstructionImpl and thus can be removed from ProcessingInstructionImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] Updated: (XERCESJ-1380) getData method is duplicated in
CharacterDataImpl and ProcessingInstructionImpl...
Posted by "Ludger Bünger (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ludger Bünger updated XERCESJ-1380:
-----------------------------------
Attachment: patch.txt
Small issue, simple fix: see attached patch.
> getData method is duplicated in CharacterDataImpl and ProcessingInstructionImpl...
> ----------------------------------------------------------------------------------
>
> Key: XERCESJ-1380
> URL: https://issues.apache.org/jira/browse/XERCESJ-1380
> Project: Xerces2-J
> Issue Type: Improvement
> Components: DOM (Level 3 Core)
> Reporter: Ludger Bünger
> Priority: Trivial
> Attachments: patch.txt
>
>
> I know, this is really trivial, but I thought I might still file a short report.
> The method getData() is duplicated with identical code in CharacterDataImpl and its descendant ProcessingInstructionImpl and thus can be removed from ProcessingInstructionImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org