You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by realdawn <gi...@git.apache.org> on 2016/01/11 08:26:55 UTC

[GitHub] incubator-hawq pull request: HAWQ-289. Fix faultinjector in client...

GitHub user realdawn opened a pull request:

    https://github.com/apache/incubator-hawq/pull/254

    HAWQ-289. Fix faultinjector in client and server for hawq

    Fix hawqfaultinjector in client and server for hawq.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/realdawn/incubator-hawq HAWQ-289

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #254
    
----
commit 4a81cf68c6666819151cc7a5ad338ce5a4bf9e7d
Author: doli <do...@pivotal.io>
Date:   2016-01-11T07:24:28Z

    HAWQ-289. Fix faultinjector in client and server for hawq

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-289. Fix faultinjector in client...

Posted by realdawn <gi...@git.apache.org>.
Github user realdawn commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/254#issuecomment-170500708
  
    It seems the faults in faultinjector.c need to be reorganized. So I close the pull request and want to make a clean up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-289. Fix faultinjector in client...

Posted by realdawn <gi...@git.apache.org>.
Github user realdawn closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-289. Fix faultinjector in client...

Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/254#issuecomment-170468657
  
    Great work! +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-289. Fix faultinjector in client...

Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/254#discussion_r49298401
  
    --- Diff: tools/bin/hawqpylib/programs/clsInjectFault.py ---
    @@ -136,7 +136,7 @@ def loadTargetSegments(self) :
             #
             # prune gpArray according to filter settings
             #
    -        hawqdbs = [hdb for hdb in hawqdbs if hdb.isSegment()]
    +        #hawqdbs = [hdb for hdb in hawqdbs if hdb.isSegment()]
    --- End diff --
    
    Remote "#hawqdbs = [hdb for hdb in hawqdbs if hdb.isSegment()]"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---