You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/23 11:14:25 UTC

[jira] [Commented] (FLINK-2609) Automatic type registration is only called from the batch execution environment

    [ https://issues.apache.org/jira/browse/FLINK-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208171#comment-15208171 ] 

ASF GitHub Bot commented on FLINK-2609:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1833

    [FLINK-2609] [streaming] auto-register types

    This PR attempts to register all streaming operator output types at kryo.
    
    In contrast to the Batch API
    * the registration is done when an operation is defined, opposed to after all operations are defined
     * autoRegistration must be disabled before an operation is created to have an effect
    * the deduplicator HashSet is a protected field of the DataStream class opposed to a local variable
     * still not visible to users
     * accessible by all DataStream's
     * accessible by Non-DataStream streams (KeyedStream etc) as long as they are in the same package
       * a separate superclass for all Streams is a good idea in the long run
    
    Most operations use DataStream#transform(), as such most registrations will take place here. One exception are key-selectors, which aremysteriously hidden in the Keyed-/Joined-/CoGroupedStreams where()/equalTo() methods, where their registration takes place.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 2609_register_types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1833
    
----
commit 286a588464b18654eed342ba0d9cc2e92646eef7
Author: zentol <ch...@apache.org>
Date:   2016-03-23T09:58:25Z

    [FLINK-2609] [streaming] auto-register types

----


> Automatic type registration is only called from the batch execution environment
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-2609
>                 URL: https://issues.apache.org/jira/browse/FLINK-2609
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.10.0
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>
> Kryo types in the streaming API are quite expensive to serialize because they are not automatically registered at Kryo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)