You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/26 12:52:34 UTC
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4379: [INLONG-4353][Sort] Optimize code structure and shading jar
dockerzhang commented on code in PR #4379:
URL: https://github.com/apache/incubator-inlong/pull/4379#discussion_r882632328
##########
inlong-distribution/pom.xml:
##########
@@ -38,20 +38,35 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>3.1.0</version>
+ <configuration>
+ <finalName>apache-${project.parent.artifactId}-${project.version}</finalName>
+ </configuration>
<executions>
<execution>
+ <id>release</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assemblies/release.xml</descriptor>
+ </descriptors>
+ </configuration>
+ </execution>
+ <execution>
+ <id>sort-plugin</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assemblies/sort-plugin.xml</descriptor>
Review Comment:
`plugin` change to `connector` may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org