[jira] [Comment Edited] (NETBEANS-311) CDDL/GPL licensed files to be resolved

["Matthias Bläsing (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NETBEANS-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339838#comment-16339838 ] 

Matthias Bläsing edited comment on NETBEANS-311 at 1/25/18 8:34 PM:
--------------------------------------------------------------------

I just noticed, that there is a whole thread on the incubator mailing list. Not sure when I will find time to work through that. I added my points to the issues here. What already added to one of the commits was, that we should not get trigger happy. Randomly removing files will not do and as a user, netbeans will be burned for me if the out of the box experience suffers (removing XSDs will do that). Removing files and moving them to a secondary location is also no solution - that just closes the eyes for reality (files are needed are part of the project).

As last productive reply - a thought for a solution:
 * add a "licenseinfo.xml" file to each module directory, that contains non-apache source files
 * let that file reference the files it covers
 * add info:
 ** are these files covered by a known license (licenseref)
 ** should these files excluded from rat (in most cases where this is needed this will be true)
 ** notice to hold additions to the notice file
 ** comment with the reasoning

This file could be verified at build-time:
 * are the referenced present
 * is the referenced license present in the license list

It could be used:
 * by reviewers to verify the reasoning
 * by the build system to:
 ** dynamicly build a rat exclude list with documented reasons
 ** pull NOTICE addtions from it
 ** include the necessary license info in the license file (I suggest to break the LICENSE file apart and reference separate files from there, that would make the file more readable)
 * by downstream users of the sources to provide the necessary info

I think having a file like this in the modules and not using a global rat exclude list would help understanding and could help with focused reviews.

I attached a sample file.


was (Author: mblaesing):
I just noticed, that there is a whole thread on the incubator mailing list. Not sure when I will find time to work through that. I added my points to the issues here. What already added to one of the commits was, that we should not get trigger happy. Randomly removing files will not do and as a user, netbeans will be burned for me if the out of the box experience suffers (removing XSDs will do that). Removing files and moving them to a secondary location is also no solution - that just closes the eyes for reality (files are needed are part of the project).

As last productive reply - a thought for a solution:
 * add a "licenseinfo.xml" file to each module directory, that contains non-apache source files
 * let that file reference the files it covers
 * add info:
 ** are these files covered by a known license (licenseref)
 ** should these files excluded from rat (in most cases where this is needed this will be true)
 ** notice to hold additions to the notice file
 ** comment with the reasoning

This file could be verified at build-time:
 * are the referenced present
 * is the referenced license present in the license list

It could be used:
 * by reviewers to verify the reasoning
 * by the build system to:
 ** dynamicly build a rat exclude list with documented reasons
 ** pull NOTICE addtions from it
 ** include the necessary license info in the license file (I suggest to break the LICENSE file apart and reference separate files from there, that would make the file more readable)
 * by downstream users of the sources to provide the necessary info

I think having a file like this in the modules and not using a global rat exclude list would help understanding and could help with focused reviews.

> CDDL/GPL licensed files to be resolved
> --------------------------------------
>
>                 Key: NETBEANS-311
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-311
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: Geertjan Wielenga
>            Priority: Major
>         Attachments: licenseinfo.xml
>
>
> j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_1_0.xsd
> j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_1_0.xsd
> websvc.saas.api/src/org/netbeans/modules/websvc/saas/model/wadl20061109.xsd
> test/unit/src/org/netbeans/modules/editor/settings/storage/compatibility/p1/SFS-Editors-Folder.zip/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists