You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/21 15:07:04 UTC

[jira] [Commented] (LUCENE-6691) tweak SortingMergePolicy.getSortDescription

    [ https://issues.apache.org/jira/browse/LUCENE-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635084#comment-14635084 ] 

ASF GitHub Bot commented on LUCENE-6691:
----------------------------------------

GitHub user cpoerschke opened a pull request:

    https://github.com/apache/lucene-solr/pull/191

    LUCENE-6691: tweak SortingMergePolicy.getSortDescription

    for https://issues.apache.org/jira/i#browse/LUCENE-6691

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-SortingMergePolicy-isSorted

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #191
    
----
commit 4626b4977f384ce9dc103531ace566da17c93205
Author: Christine Poerschke <cp...@bloomberg.net>
Date:   2015-07-16T19:42:21Z

    lucene: add EarlyTerminatingSortingCollector.terminatedEarly() method

commit 6b7a11c0ced960f80152aed2c582cfaa6217c0af
Author: Christine Poerschke <cp...@bloomberg.net>
Date:   2015-07-17T15:46:39Z

    lucene: add TestEarlyTerminatingSortingCollector.testTerminatedEarly()

commit 2afd60f6d29b5d4759a3eaf6ed1aef22a368bedb
Author: Christine Poerschke <cp...@bloomberg.net>
Date:   2015-07-20T12:54:04Z

    lucene: tweak SortingMergePolicy.getSortDescription(LeafReader reader)

----


> tweak SortingMergePolicy.getSortDescription
> -------------------------------------------
>
>                 Key: LUCENE-6691
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6691
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> Building tests for SOLR-5730 identified that early termination can be omitted for sorted segments because the {{LeafReader}} concerned is not a {{SegmentReader}} - github pull request to illustrate to follow:
> * the {{TestEarlyTerminatingSortingCollector.testTerminatedEarly}} test uses a wrapped reader in the same way as {{SolrIndexSearcher}}
> * the {{SortingMergePolicy.getSortDescription}} change (assuming it is a valid change to make) fixes that particular test only
> * {{ExitableDirectoryReader}} and {{UninvertingReader}} wrap could perhaps also be added in {{LuceneTestCase.wrapReader}} ?
> LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead." also concerns SortingMergePolicy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org