You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/18 07:49:55 UTC
[GitHub] [arrow] sanjibansg opened a new pull request, #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
sanjibansg opened a new pull request, #14445:
URL: https://github.com/apache/arrow/pull/14445
This PR modifies the `DecorateWithRowNumber` method in the `DataBatch` class to return an unknown error to avoid getting a compilation warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14445:
URL: https://github.com/apache/arrow/pull/14445#issuecomment-1292307687
Rebased to hopefully fix CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14445:
URL: https://github.com/apache/arrow/pull/14445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14445:
URL: https://github.com/apache/arrow/pull/14445#discussion_r998637349
##########
cpp/src/arrow/csv/parser.h:
##########
@@ -121,6 +121,7 @@ class ARROW_EXPORT DataBatch {
}
// Use return_if so that when extra context is enabled it will be added
ARROW_RETURN_IF_(true, std::move(status), ARROW_STRINGIFY(status));
+ return Status::UnknownError("Unknown error while decorating with row number.");
Review Comment:
Why not simply
```suggestion
return status;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a diff in pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on code in PR #14445:
URL: https://github.com/apache/arrow/pull/14445#discussion_r1000587936
##########
cpp/src/arrow/csv/parser.h:
##########
@@ -121,6 +121,7 @@ class ARROW_EXPORT DataBatch {
}
// Use return_if so that when extra context is enabled it will be added
ARROW_RETURN_IF_(true, std::move(status), ARROW_STRINGIFY(status));
+ return Status::UnknownError("Unknown error while decorating with row number.");
Review Comment:
Yes, correct, made the change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14445:
URL: https://github.com/apache/arrow/pull/14445#issuecomment-1295615885
Benchmark runs are scheduled for baseline = 7b2fc0d05108f068d227fa5bbc35a6726f837c99 and contender = b87370d6071cdb9313430e14482cbc4f7ad05e35. b87370d6071cdb9313430e14482cbc4f7ad05e35 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f5269ef535cc4c8081d8eab75ae31067...0199479143e34c55bf839665d80c6310/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7a9e7955e3924613847c5103fc85f394...63b47f644862439499de1657b9f90b24/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2323aa5882d54c2fa32d765744efa431...d1ab65537d964c1eab90f509cc6471cf/)
[Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cca5353736264a4d817b570aa93d8da9...34dd32ed67384fcda5da9f3fd3c181e3/)
Buildkite builds:
[Finished] [`b87370d6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1770)
[Failed] [`b87370d6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1791)
[Finished] [`b87370d6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1757)
[Finished] [`b87370d6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1783)
[Finished] [`7b2fc0d0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1769)
[Failed] [`7b2fc0d0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1790)
[Finished] [`7b2fc0d0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1756)
[Finished] [`7b2fc0d0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1782)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14445:
URL: https://github.com/apache/arrow/pull/14445#issuecomment-1281973104
https://issues.apache.org/jira/browse/ARROW-17858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14445:
URL: https://github.com/apache/arrow/pull/14445#issuecomment-1292382955
Thank you for contributing @sanjibansg !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14445: ARROW-17858: [C++] Compilating warning in arrow/csv/parser.h
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14445:
URL: https://github.com/apache/arrow/pull/14445#issuecomment-1292382378
CI is green on author's fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org