You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/04 03:17:25 UTC
[GitHub] [superset] john-bodley opened a new pull request, #19941: fix(reports): Clear last value when state is WORKING
john-bodley opened a new pull request, #19941:
URL: https://github.com/apache/superset/pull/19941
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This PR fixes an issue with the alert feature, specifically the execution log reports different alert values for different states within the same execution run. Per [this](https://apache-superset.slack.com/archives/G013HAE6Y0K/p1651543102805559) Slack thread the underlying issue is the report schedule synopsis—from which the execution log is created, i.e., a point-in-time snapshot—is when the state is `WORKING` the `last_value` and `last_value_row_json` need to be cleared otherwise they incorrectly reflect the values of the previous execution run.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before Migration
<img width="1335" alt="Screen Shot 2022-05-03 at 8 06 09 PM" src="https://user-images.githubusercontent.com/4567245/166618425-b871ea01-6897-4d23-986b-7c2fd9fcfec1.png">
#### After Migration
<img width="1348" alt="Screen Shot 2022-05-03 at 8 06 37 PM" src="https://user-images.githubusercontent.com/4567245/166618440-76d38a6d-abc3-43bb-896a-f31f34f26f27.png">
### TESTING INSTRUCTIONS
Added unit tests and migration. The migration successfully ran in under a minute on a replica of Airbnb's production database with ~ 50,000 execution logs.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [x] Migration is atomic, supports rollback & is backwards-compatible
- [x] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
john-bodley merged PR #19941:
URL: https://github.com/apache/superset/pull/19941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
john-bodley commented on PR #19941:
URL: https://github.com/apache/superset/pull/19941#issuecomment-1125640141
I think this PR makes things less wrong so it's directionally correct. There's likely merit in rethinking what the desirable UX is from a reporting standpoint, though that can be handled in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #19941:
URL: https://github.com/apache/superset/pull/19941#issuecomment-1121691314
>I’m actually not sure whether there’s any value logging the WORKING state to the execution log. Does it provide any relevant information to the user?
@john-bodley I suppose it could give the user a start time. It's usually the same as the scheduled time, but if the report is taking a long time to run, it could indicate to the user that something is happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #19941:
URL: https://github.com/apache/superset/pull/19941#issuecomment-1121690019
> Is the report scheduler currently adding two execution logs for every execution, one in WORKING state, one in COMPLETE? Was the original intention to update current WORKING execution to COMPLETE (or FAILED) once an execution is done?
No, the logs are immutable, so you'll get two logs, one for each state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
john-bodley commented on code in PR #19941:
URL: https://github.com/apache/superset/pull/19941#discussion_r871988371
##########
superset/migrations/versions/cbe71abde154_fix_report_schedule_and_log.py:
##########
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""fix report schedule and execution log
+
+Revision ID: cbe71abde154
+Revises: a9422eeaae74
+Create Date: 2022-05-03 19:39:32.074608
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "cbe71abde154"
+down_revision = "a9422eeaae74"
+
+from alembic import op
+from sqlalchemy import Column, Float, Integer, String, Text
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+from superset.models.reports import ReportState
+
+Base = declarative_base()
+
+
+class ReportExecutionLog(Base):
+ __tablename__ = "report_execution_log"
+
+ id = Column(Integer, primary_key=True)
+ state = Column(String(50), nullable=False)
+ value = Column(Float)
+ value_row_json = Column(Text)
+
+
+class ReportSchedule(Base):
+ __tablename__ = "report_schedule"
+
+ id = Column(Integer, primary_key=True)
+ last_state = Column(String(50))
+ last_value = Column(Float)
+ last_value_row_json = Column(Text)
+
+
+def upgrade():
+ bind = op.get_bind()
+ session = db.Session(bind=bind)
+
+ for schedule in (
+ session.query(ReportSchedule)
+ .filter(ReportSchedule.last_state == ReportState.WORKING)
+ .all()
+ ):
+ schedule.last_value = None
+ schedule.last_value_row_json = None
Review Comment:
@eschutho I guess with any migration there's a risk of a race condition happening whilst the migration is running. I've replicated the `session.commit()` to ensure that there's also a commit directly after the `ReportSchedule` which likely only has a handful of reports in `WORKING` state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
john-bodley commented on code in PR #19941:
URL: https://github.com/apache/superset/pull/19941#discussion_r864431581
##########
superset/reports/commands/execute.py:
##########
@@ -94,35 +94,39 @@ def __init__(
self._start_dttm = datetime.utcnow()
self._execution_id = execution_id
- def set_state_and_log(
+ def update_report_schedule_and_log(
Review Comment:
I felt that `update_report_schedule_and_log` was more reflective of the function logic.
##########
superset/reports/commands/execute.py:
##########
@@ -94,35 +94,39 @@ def __init__(
self._start_dttm = datetime.utcnow()
self._execution_id = execution_id
- def set_state_and_log(
+ def update_report_schedule_and_log(
self,
state: ReportState,
error_message: Optional[str] = None,
) -> None:
"""
- Updates current ReportSchedule state and TS. If on final state writes the log
- for this execution
+ Update the report schedule state et al. and reflect the change in the execution
+ log.
"""
- now_dttm = datetime.utcnow()
- self.set_state(state, now_dttm)
- self.create_log(
- state,
- error_message=error_message,
- )
- def set_state(self, state: ReportState, dttm: datetime) -> None:
+ self.update_report_schedule(state)
+ self.create_log(error_message)
+
+ def update_report_schedule(self, state: ReportState) -> None:
"""
- Set the current report schedule state, on this case we want to
- commit immediately
+ Update the report schedule state et al.
+
+ When the report state is WORKING we must ensure that the values from the last
+ execution run are cleared to ensure that they are not propagated to the
+ execution log.
"""
+
+ if state == ReportState.WORKING:
+ self._report_schedule.last_value = None
+ self._report_schedule.last_value_row_json = None
+
self._report_schedule.last_state = state
- self._report_schedule.last_eval_dttm = dttm
+ self._report_schedule.last_eval_dttm = datetime.utcnow()
Review Comment:
There's no need to pass in the timestamp which isn't used elsewhere.
##########
superset/reports/commands/execute.py:
##########
@@ -132,7 +136,7 @@ def create_log(
end_dttm=datetime.utcnow(),
value=self._report_schedule.last_value,
value_row_json=self._report_schedule.last_value_row_json,
- state=state,
+ state=self._report_schedule.state,
Review Comment:
There's no need to pass in the state given the report schedule record has been updated with the new state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #19941:
URL: https://github.com/apache/superset/pull/19941#issuecomment-1121702948
> No, I don't believe this was the intention.
Then I don't understand why we have an [`end_dttm`](https://github.com/apache/superset/blob/6903c48c96fac555ca08fef3255c54522479f387/superset/models/reports.py#L204) (and "duration") for each log? If we are not updating the log record, i.e., it is a "fire and forgot" operation, shouldn't a `start_ddm` be enough? The log list table is also less readable when you have duplicate records with one having empty values and one having a spinner icon that never changes state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #19941:
URL: https://github.com/apache/superset/pull/19941#discussion_r868586449
##########
superset/migrations/versions/cbe71abde154_fix_report_schedule_and_log.py:
##########
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""fix report schedule and execution log
+
+Revision ID: cbe71abde154
+Revises: a9422eeaae74
+Create Date: 2022-05-03 19:39:32.074608
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "cbe71abde154"
+down_revision = "a9422eeaae74"
+
+from alembic import op
+from sqlalchemy import Column, Float, Integer, String, Text
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+from superset.models.reports import ReportState
+
+Base = declarative_base()
+
+
+class ReportExecutionLog(Base):
+ __tablename__ = "report_execution_log"
+
+ id = Column(Integer, primary_key=True)
+ state = Column(String(50), nullable=False)
+ value = Column(Float)
+ value_row_json = Column(Text)
+
+
+class ReportSchedule(Base):
+ __tablename__ = "report_schedule"
+
+ id = Column(Integer, primary_key=True)
+ last_state = Column(String(50))
+ last_value = Column(Float)
+ last_value_row_json = Column(Text)
+
+
+def upgrade():
+ bind = op.get_bind()
+ session = db.Session(bind=bind)
+
+ for schedule in (
+ session.query(ReportSchedule)
+ .filter(ReportSchedule.last_state == ReportState.WORKING)
+ .all()
+ ):
+ schedule.last_value = None
+ schedule.last_value_row_json = None
Review Comment:
@john-bodley do you think there's a chance that if there is a report that's in a working state, that we could potentially wind up altering the value after the report has completed? Just based off your migration timing of around a minute and most of these reports take under a minute to run, we may wind up with some reports that wind up with a completed state and no value, i.e., the commit happens here after the state has changed on the report side. Just wondering if it's safer not to change reports that are in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #19941:
URL: https://github.com/apache/superset/pull/19941#issuecomment-1118095214
Is the report scheduler currently adding two execution logs for every execution, one in WORKING state, one in COMPLETE? Was the original intention to update the current WORKING execution to COMPLETE once the execution is done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19941: fix(reports): Clear last value when state is WORKING
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19941:
URL: https://github.com/apache/superset/pull/19941#issuecomment-1116891508
# [Codecov](https://codecov.io/gh/apache/superset/pull/19941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19941](https://codecov.io/gh/apache/superset/pull/19941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39d2abf) into [master](https://codecov.io/gh/apache/superset/commit/aff10a7fad0b6a48c578e70d2746d04bdf4d753c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aff10a7) will **decrease** coverage by `12.74%`.
> The diff coverage is `13.04%`.
```diff
@@ Coverage Diff @@
## master #19941 +/- ##
===========================================
- Coverage 66.52% 53.78% -12.75%
===========================================
Files 1714 1713 -1
Lines 65052 65052
Branches 6722 6722
===========================================
- Hits 43279 34987 -8292
- Misses 20061 28353 +8292
Partials 1712 1712
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.75% <13.04%> (-0.01%)` | :arrow_down: |
| python | `56.41% <13.04%> (-26.00%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `48.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `24.17% <13.04%> (-67.34%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/key\_value/commands/upsert.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3Vwc2VydC5weQ==) | `0.00% <0.00%> (-89.59%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-89.37%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-85.30%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/key\_value/commands/delete\_expired.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZV9leHBpcmVkLnB5) | `0.00% <0.00%> (-80.77%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `14.79% <0.00%> (-75.15%)` | :arrow_down: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `24.82% <0.00%> (-68.80%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `31.42% <0.00%> (-68.58%)` | :arrow_down: |
| ... and [270 more](https://codecov.io/gh/apache/superset/pull/19941/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19941?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19941?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aff10a7...39d2abf](https://codecov.io/gh/apache/superset/pull/19941?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org