You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@toree.apache.org by lr...@apache.org on 2018/07/27 15:12:14 UTC

[1/3] incubator-toree git commit: [MINOR] Fix typo on variable name

Repository: incubator-toree
Updated Branches:
  refs/heads/master 64d2ee8c4 -> a8b746a2a


[MINOR] Fix typo on variable name


Project: http://git-wip-us.apache.org/repos/asf/incubator-toree/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-toree/commit/c894999b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-toree/tree/c894999b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-toree/diff/c894999b

Branch: refs/heads/master
Commit: c894999b03f2c4b96ba9d6581424dbf3c5e4b64a
Parents: 64d2ee8
Author: Luciano Resende <lr...@apache.org>
Authored: Fri Jun 15 00:25:49 2018 -0700
Committer: Luciano Resende <lr...@apache.org>
Committed: Fri Jun 15 00:25:49 2018 -0700

----------------------------------------------------------------------
 .../src/test/scala-2.11/scala/ScalaInterpreterSpec.scala  |  1 +
 .../main/scala/org/apache/toree/magic/builtin/Sql.scala   | 10 +++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-toree/blob/c894999b/scala-interpreter/src/test/scala-2.11/scala/ScalaInterpreterSpec.scala
----------------------------------------------------------------------
diff --git a/scala-interpreter/src/test/scala-2.11/scala/ScalaInterpreterSpec.scala b/scala-interpreter/src/test/scala-2.11/scala/ScalaInterpreterSpec.scala
index dfe3da6..19eb78f 100644
--- a/scala-interpreter/src/test/scala-2.11/scala/ScalaInterpreterSpec.scala
+++ b/scala-interpreter/src/test/scala-2.11/scala/ScalaInterpreterSpec.scala
@@ -455,6 +455,7 @@ class ScalaInterpreterSpec extends FunSpec
 
         interpreter.stop()
       }
+
     }
   }
 }

http://git-wip-us.apache.org/repos/asf/incubator-toree/blob/c894999b/sql-interpreter/src/main/scala/org/apache/toree/magic/builtin/Sql.scala
----------------------------------------------------------------------
diff --git a/sql-interpreter/src/main/scala/org/apache/toree/magic/builtin/Sql.scala b/sql-interpreter/src/main/scala/org/apache/toree/magic/builtin/Sql.scala
index 35f033f..3dcf7e7 100644
--- a/sql-interpreter/src/main/scala/org/apache/toree/magic/builtin/Sql.scala
+++ b/sql-interpreter/src/main/scala/org/apache/toree/magic/builtin/Sql.scala
@@ -29,14 +29,14 @@ class Sql extends CellMagic with IncludeKernel {
 
   @Event(name = "sql")
   override def execute(code: String): MagicOutput = {
-    val sparkR = kernel.interpreter("SQL")
+    val sparkSQL = kernel.interpreter("SQL")
 
-    if (sparkR.isEmpty || sparkR.get == null)
+    if (sparkSQL.isEmpty || sparkSQL.get == null)
       throw new SqlException("SQL is not available!")
 
-    sparkR.get match {
-      case sparkRInterpreter: SqlInterpreter =>
-        val (_, output) = sparkRInterpreter.interpret(code)
+    sparkSQL.get match {
+      case sparkSQLInterpreter: SqlInterpreter =>
+        val (_, output) = sparkSQLInterpreter.interpret(code)
         output match {
           case Left(executeOutput) =>
             MagicOutput(executeOutput.toSeq:_*)


[3/3] incubator-toree git commit: [MINOR] Disable intermitent failing test case

Posted by lr...@apache.org.
[MINOR] Disable intermitent failing test case


Project: http://git-wip-us.apache.org/repos/asf/incubator-toree/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-toree/commit/a8b746a2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-toree/tree/a8b746a2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-toree/diff/a8b746a2

Branch: refs/heads/master
Commit: a8b746a2a81392063a24d1e56d5c2eef91c544a1
Parents: b3cf60f
Author: Luciano Resende <lr...@apache.org>
Authored: Fri Jul 27 11:11:53 2018 -0400
Committer: Luciano Resende <lr...@apache.org>
Committed: Fri Jul 27 11:11:53 2018 -0400

----------------------------------------------------------------------
 .../scala/AddExternalJarMagicSpecForIntegration.scala            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-toree/blob/a8b746a2/scala-interpreter/src/test/scala/integration/interpreter/scala/AddExternalJarMagicSpecForIntegration.scala
----------------------------------------------------------------------
diff --git a/scala-interpreter/src/test/scala/integration/interpreter/scala/AddExternalJarMagicSpecForIntegration.scala b/scala-interpreter/src/test/scala/integration/interpreter/scala/AddExternalJarMagicSpecForIntegration.scala
index 5fe29ff..45208f7 100644
--- a/scala-interpreter/src/test/scala/integration/interpreter/scala/AddExternalJarMagicSpecForIntegration.scala
+++ b/scala-interpreter/src/test/scala/integration/interpreter/scala/AddExternalJarMagicSpecForIntegration.scala
@@ -18,7 +18,6 @@
 package integration.interpreter.scala
 
 import java.io.{ByteArrayOutputStream, File}
-import java.net.URL
 
 import org.apache.spark.toree.test.utils.JarUtils
 import org.apache.toree.annotations.SbtForked
@@ -27,9 +26,10 @@ import org.apache.toree.interpreter._
 import org.apache.toree.kernel.api.KernelLike
 import org.apache.toree.kernel.interpreter.scala.ScalaInterpreter
 import org.scalatest.mock.MockitoSugar
-import org.scalatest.{BeforeAndAfter, FunSpec, Matchers}
+import org.scalatest.{BeforeAndAfter, FunSpec, Ignore, Matchers}
 
 @SbtForked
+@Ignore
 class AddExternalJarMagicSpecForIntegration
   extends FunSpec with Matchers with MockitoSugar with BeforeAndAfter
 {


[2/3] incubator-toree git commit: [MINOR] Update deprecated Java 7 JVM options

Posted by lr...@apache.org.
[MINOR] Update deprecated Java 7 JVM options


Project: http://git-wip-us.apache.org/repos/asf/incubator-toree/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-toree/commit/b3cf60ff
Tree: http://git-wip-us.apache.org/repos/asf/incubator-toree/tree/b3cf60ff
Diff: http://git-wip-us.apache.org/repos/asf/incubator-toree/diff/b3cf60ff

Branch: refs/heads/master
Commit: b3cf60ff9c928df8230e82cad72cffbdf7f97b2b
Parents: c894999
Author: Luciano Resende <lr...@apache.org>
Authored: Thu Jul 26 11:11:59 2018 -0400
Committer: Luciano Resende <lr...@apache.org>
Committed: Thu Jul 26 11:11:59 2018 -0400

----------------------------------------------------------------------
 .jvmopts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-toree/blob/b3cf60ff/.jvmopts
----------------------------------------------------------------------
diff --git a/.jvmopts b/.jvmopts
index bbd3597..3c565ee 100644
--- a/.jvmopts
+++ b/.jvmopts
@@ -17,7 +17,9 @@
 -Xms1024M
 -Xmx4096M
 -Xss2m
--XX:MaxPermSize=1024M
+-XX:MetaspaceSize=1024m
+-XX:+UseCompressedOops
+-XX:+UseCompressedClassPointers
 -XX:ReservedCodeCacheSize=256M
 -XX:+TieredCompilation
 -XX:+CMSPermGenSweepingEnabled