You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/03/18 12:56:49 UTC
[jira] [Commented] (FELIX-2702) File Install should be smarter
about starting failed bundles
[ https://issues.apache.org/jira/browse/FELIX-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939106#comment-13939106 ]
ASF GitHub Bot commented on FELIX-2702:
---------------------------------------
GitHub user grgrzybek opened a pull request:
https://github.com/apache/felix/pull/5
[FELIX-2702] Start failing bundles when there's a change in bundles state
starting bundles.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grgrzybek/felix FELIX-2702
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit dc02abde7d338e175e23dc5cc74172562c2dc386
Author: Grzegorz Grzybek <gr...@gmail.com>
Date: 2014-03-17T15:49:43Z
[FELIX-2702] Monitoring system state to check whether to reattempt
starting bundles.
----
> File Install should be smarter about starting failed bundles
> ------------------------------------------------------------
>
> Key: FELIX-2702
> URL: https://issues.apache.org/jira/browse/FELIX-2702
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Affects Versions: fileinstall-3.0.2
> Reporter: David Hay
> Priority: Minor
>
> When the File Install bundle tries to start a bundle and there are errors (e.g. unresolved imports), it keeps trying to start that bundle even though nothing about the system has changed. It seems like File Install could check if the contents of the felix.fileinstall.dir have changed since the last time it checked as well as installing a BundleListener to determine if it's worth trying to start a bundle that failed before.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: [jira] [Commented] (FELIX-2702) File Install should be smarter
about starting failed bundles
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 3/18/14, 08:29 , Guillaume Nodet wrote:
> Well, there are benefits of using git branches and PRs rather than patches:
> it's easier and preserve the authorship of the patch.
> I like it.
It is not clear why GitHub is special. Are we going to be happy when
people with other choices for scm give us links to patches instead of
attachments?
To me, this isn't about whether or not Felix uses git...scm is scm and
git is just different than svn, not really better or worse. The issue I
raise is more about our process.
Even if we switched to git, I'd still like to have patches attached to
issues, rather than links to patches.
-> richard
>
>
> 2014-03-18 13:23 GMT+01:00 Richard S. Hall <he...@ungoverned.org>:
>
>> I would assume this is an automated system...
>>
>> If so, why can they not just attach the patch to the issue so we can keep
>> our JIRA issues self contained and not have to start relying on a
>> third-party patch hosting system?
>>
>> -> richard
>>
>>
>> On 3/18/14, 07:56 , ASF GitHub Bot (JIRA) wrote:
>>
>>> [ https://issues.apache.org/jira/browse/FELIX-2702?page=
>>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>>> tabpanel&focusedCommentId=13939106#comment-13939106 ]
>>>
>>> ASF GitHub Bot commented on FELIX-2702:
>>> ---------------------------------------
>>>
>>> GitHub user grgrzybek opened a pull request:
>>>
>>> https://github.com/apache/felix/pull/5
>>>
>>> [FELIX-2702] Start failing bundles when there's a change in bundles
>>> state
>>>
>>> starting bundles.
>>>
>>> You can merge this pull request into a Git repository by running:
>>>
>>> $ git pull https://github.com/grgrzybek/felix FELIX-2702
>>>
>>> Alternatively you can review and apply these changes as the patch at:
>>>
>>> https://github.com/apache/felix/pull/5.patch
>>>
>>> To close this pull request, make a commit to your master/trunk branch
>>> with (at least) the following in the commit message:
>>>
>>> This closes #5
>>> ----
>>> commit dc02abde7d338e175e23dc5cc74172562c2dc386
>>> Author: Grzegorz Grzybek <gr...@gmail.com>
>>> Date: 2014-03-17T15:49:43Z
>>>
>>> [FELIX-2702] Monitoring system state to check whether to reattempt
>>> starting bundles.
>>>
>>> ----
>>>
>>>
>>> File Install should be smarter about starting failed bundles
>>>> ------------------------------------------------------------
>>>>
>>>> Key: FELIX-2702
>>>> URL: https://issues.apache.org/jira/browse/FELIX-2702
>>>> Project: Felix
>>>> Issue Type: Improvement
>>>> Components: File Install
>>>> Affects Versions: fileinstall-3.0.2
>>>> Reporter: David Hay
>>>> Priority: Minor
>>>>
>>>> When the File Install bundle tries to start a bundle and there are
>>>> errors (e.g. unresolved imports), it keeps trying to start that bundle even
>>>> though nothing about the system has changed. It seems like File Install
>>>> could check if the contents of the felix.fileinstall.dir have changed since
>>>> the last time it checked as well as installing a BundleListener to
>>>> determine if it's worth trying to start a bundle that failed before.
>>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.2#6252)
>>>
>>
Re: [jira] [Commented] (FELIX-2702) File Install should be smarter
about starting failed bundles
Posted by Guillaume Nodet <gn...@apache.org>.
Well, I forgot Felix doesn't use git yet. Maybe we should discuss
switching. I only see benefits fwiw.
2014-03-18 13:29 GMT+01:00 Guillaume Nodet <gn...@apache.org>:
> Well, there are benefits of using git branches and PRs rather than
> patches: it's easier and preserve the authorship of the patch.
> I like it.
>
>
> 2014-03-18 13:23 GMT+01:00 Richard S. Hall <he...@ungoverned.org>:
>
> I would assume this is an automated system...
>>
>> If so, why can they not just attach the patch to the issue so we can keep
>> our JIRA issues self contained and not have to start relying on a
>> third-party patch hosting system?
>>
>> -> richard
>>
>>
>> On 3/18/14, 07:56 , ASF GitHub Bot (JIRA) wrote:
>>
>>> [ https://issues.apache.org/jira/browse/FELIX-2702?page=
>>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>>> tabpanel&focusedCommentId=13939106#comment-13939106 ]
>>>
>>> ASF GitHub Bot commented on FELIX-2702:
>>> ---------------------------------------
>>>
>>> GitHub user grgrzybek opened a pull request:
>>>
>>> https://github.com/apache/felix/pull/5
>>>
>>> [FELIX-2702] Start failing bundles when there's a change in bundles
>>> state
>>>
>>> starting bundles.
>>>
>>> You can merge this pull request into a Git repository by running:
>>>
>>> $ git pull https://github.com/grgrzybek/felix FELIX-2702
>>>
>>> Alternatively you can review and apply these changes as the patch at:
>>>
>>> https://github.com/apache/felix/pull/5.patch
>>>
>>> To close this pull request, make a commit to your master/trunk branch
>>> with (at least) the following in the commit message:
>>>
>>> This closes #5
>>> ----
>>> commit dc02abde7d338e175e23dc5cc74172562c2dc386
>>> Author: Grzegorz Grzybek <gr...@gmail.com>
>>> Date: 2014-03-17T15:49:43Z
>>>
>>> [FELIX-2702] Monitoring system state to check whether to reattempt
>>> starting bundles.
>>>
>>> ----
>>>
>>>
>>> File Install should be smarter about starting failed bundles
>>>> ------------------------------------------------------------
>>>>
>>>> Key: FELIX-2702
>>>> URL: https://issues.apache.org/jira/browse/FELIX-2702
>>>> Project: Felix
>>>> Issue Type: Improvement
>>>> Components: File Install
>>>> Affects Versions: fileinstall-3.0.2
>>>> Reporter: David Hay
>>>> Priority: Minor
>>>>
>>>> When the File Install bundle tries to start a bundle and there are
>>>> errors (e.g. unresolved imports), it keeps trying to start that bundle even
>>>> though nothing about the system has changed. It seems like File Install
>>>> could check if the contents of the felix.fileinstall.dir have changed since
>>>> the last time it checked as well as installing a BundleListener to
>>>> determine if it's worth trying to start a bundle that failed before.
>>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.2#6252)
>>>
>>
>>
>
Re: [jira] [Commented] (FELIX-2702) File Install should be smarter
about starting failed bundles
Posted by Guillaume Nodet <gn...@apache.org>.
Well, there are benefits of using git branches and PRs rather than patches:
it's easier and preserve the authorship of the patch.
I like it.
2014-03-18 13:23 GMT+01:00 Richard S. Hall <he...@ungoverned.org>:
> I would assume this is an automated system...
>
> If so, why can they not just attach the patch to the issue so we can keep
> our JIRA issues self contained and not have to start relying on a
> third-party patch hosting system?
>
> -> richard
>
>
> On 3/18/14, 07:56 , ASF GitHub Bot (JIRA) wrote:
>
>> [ https://issues.apache.org/jira/browse/FELIX-2702?page=
>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel&focusedCommentId=13939106#comment-13939106 ]
>>
>> ASF GitHub Bot commented on FELIX-2702:
>> ---------------------------------------
>>
>> GitHub user grgrzybek opened a pull request:
>>
>> https://github.com/apache/felix/pull/5
>>
>> [FELIX-2702] Start failing bundles when there's a change in bundles
>> state
>>
>> starting bundles.
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/grgrzybek/felix FELIX-2702
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/felix/pull/5.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>> This closes #5
>> ----
>> commit dc02abde7d338e175e23dc5cc74172562c2dc386
>> Author: Grzegorz Grzybek <gr...@gmail.com>
>> Date: 2014-03-17T15:49:43Z
>>
>> [FELIX-2702] Monitoring system state to check whether to reattempt
>> starting bundles.
>>
>> ----
>>
>>
>> File Install should be smarter about starting failed bundles
>>> ------------------------------------------------------------
>>>
>>> Key: FELIX-2702
>>> URL: https://issues.apache.org/jira/browse/FELIX-2702
>>> Project: Felix
>>> Issue Type: Improvement
>>> Components: File Install
>>> Affects Versions: fileinstall-3.0.2
>>> Reporter: David Hay
>>> Priority: Minor
>>>
>>> When the File Install bundle tries to start a bundle and there are
>>> errors (e.g. unresolved imports), it keeps trying to start that bundle even
>>> though nothing about the system has changed. It seems like File Install
>>> could check if the contents of the felix.fileinstall.dir have changed since
>>> the last time it checked as well as installing a BundleListener to
>>> determine if it's worth trying to start a bundle that failed before.
>>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.2#6252)
>>
>
>
Re: [jira] [Commented] (FELIX-2702) File Install should be smarter
about starting failed bundles
Posted by "Richard S. Hall" <he...@ungoverned.org>.
I would assume this is an automated system...
If so, why can they not just attach the patch to the issue so we can
keep our JIRA issues self contained and not have to start relying on a
third-party patch hosting system?
-> richard
On 3/18/14, 07:56 , ASF GitHub Bot (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/FELIX-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939106#comment-13939106 ]
>
> ASF GitHub Bot commented on FELIX-2702:
> ---------------------------------------
>
> GitHub user grgrzybek opened a pull request:
>
> https://github.com/apache/felix/pull/5
>
> [FELIX-2702] Start failing bundles when there's a change in bundles state
>
> starting bundles.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/grgrzybek/felix FELIX-2702
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/felix/pull/5.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #5
>
> ----
> commit dc02abde7d338e175e23dc5cc74172562c2dc386
> Author: Grzegorz Grzybek <gr...@gmail.com>
> Date: 2014-03-17T15:49:43Z
>
> [FELIX-2702] Monitoring system state to check whether to reattempt
> starting bundles.
>
> ----
>
>
>> File Install should be smarter about starting failed bundles
>> ------------------------------------------------------------
>>
>> Key: FELIX-2702
>> URL: https://issues.apache.org/jira/browse/FELIX-2702
>> Project: Felix
>> Issue Type: Improvement
>> Components: File Install
>> Affects Versions: fileinstall-3.0.2
>> Reporter: David Hay
>> Priority: Minor
>>
>> When the File Install bundle tries to start a bundle and there are errors (e.g. unresolved imports), it keeps trying to start that bundle even though nothing about the system has changed. It seems like File Install could check if the contents of the felix.fileinstall.dir have changed since the last time it checked as well as installing a BundleListener to determine if it's worth trying to start a bundle that failed before.
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)