You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/11/19 16:13:52 UTC
[GitHub] [cassandra] ifesdjeen opened a new pull request #828: Make relocate dependencies script less manual
ifesdjeen opened a new pull request #828:
URL: https://github.com/apache/cassandra/pull/828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #828:
URL: https://github.com/apache/cassandra/pull/828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r544698400
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
+cp .//build/lib/jars/javassist-3.26.0-GA.jar ./lib
+
ARTIFACT_NAME=cassandra-dtest
REPO_DIR=~/.m2/repository
+CASSANDRA_VERSION=$(cat build.xml | grep 'property name="base.version"' | awk -F "\"" '{print $4}')
+DTEST_VERSION=$(cat relocate-dependencies.pom | grep "dtest-local.version>" | awk -F "\>|\<" '{print $3}')
Review comment:
I won't block fixing this for this ticket, but would be good to have a single point of truth, as I feel that relocate-dependencies.pom will be neglected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ifesdjeen commented on a change in pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
ifesdjeen commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r539129322
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
+cp .//build/lib/jars/javassist-3.26.0-GA.jar ./lib
+
ARTIFACT_NAME=cassandra-dtest
REPO_DIR=~/.m2/repository
+CASSANDRA_VERSION=$(cat build.xml | grep 'property name="base.version"' | awk -F "\"" '{print $4}')
+DTEST_VERSION=$(cat relocate-dependencies.pom | grep "dtest-local.version>" | awk -F "\>|\<" '{print $3}')
Review comment:
@dcapwell the point of this patch was specifically to avoid anyone to have to manage this version. I've changed it from `4.0.1-SNAPSHOT` to `4.0-beta4-SNAPSHOT`, since we'll need to publish it several times. Howver, if someone either forgets or has different values for the two by mistake, it'll still work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r527178836
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
+cp .//build/lib/jars/javassist-3.26.0-GA.jar ./lib
+
ARTIFACT_NAME=cassandra-dtest
REPO_DIR=~/.m2/repository
+CASSANDRA_VERSION=$(cat build.xml | grep 'property name="base.version"' | awk -F "\"" '{print $4}')
+DTEST_VERSION=$(cat relocate-dependencies.pom | grep "dtest-local.version>" | awk -F "\>|\<" '{print $3}')
Review comment:
true, this line doesn't get the DTEST_VERSION. As I was in a rush last night just to run it, I hardcoded the version on my own to make it run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r536419798
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
Review comment:
believe this is fixed now, correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ifesdjeen commented on a change in pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
ifesdjeen commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r539125976
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
Review comment:
Ah, this is definitely fixed, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #828: Make relocate dependencies script less manual
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r527155511
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
+cp .//build/lib/jars/javassist-3.26.0-GA.jar ./lib
+
ARTIFACT_NAME=cassandra-dtest
REPO_DIR=~/.m2/repository
+CASSANDRA_VERSION=$(cat build.xml | grep 'property name="base.version"' | awk -F "\"" '{print $4}')
+DTEST_VERSION=$(cat relocate-dependencies.pom | grep "dtest-local.version>" | awk -F "\>|\<" '{print $3}')
Review comment:
how are we expected to manage this version? it seems decoupled from CASSANDRA-VERSION and doesn't actually show the dtest-api version; should we not just have this match the CASSANDRA_VERSIOn?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org