You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/14 13:48:14 UTC
[GitHub] [beam] bvolpato opened a new pull request, #24156: Use only ValueProviders in SpannerConfig
bvolpato opened a new pull request, #24156:
URL: https://github.com/apache/beam/pull/24156
Fine-grained access control was added to Spanner, and the property DatabaseRole was added to Beam's SpannerConfig (https://github.com/apache/beam/pull/23377).
However, unlike the rest of the configuration class, ValueProvider support wasn't added, which is necessary to use it in Template jobs (more information [here]( https://cloud.google.com/dataflow/docs/guides/templates/creating-templates#use-valueprovider-in-your-pipeline-options)).
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] ~Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.~
- [ ] ~Update `CHANGES.md` with noteworthy changes~.
- [x] ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)~.
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
bvolpato commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1314079843
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
bvolpato commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1315630856
We have a couple of Legacy/Classic templates for Spanner [1]. I agree on new templates being Flex, that's a route we want to pursue, including migrating classic to Flex when feasible.
With this change in specific, we have some inheritance from Beam that requires some rework, so I am trying to keep it consistent.
Not changing to a ValueProvider would mean that we can only configure a subset of the parameters.
[1] https://github.com/GoogleCloudPlatform/DataflowTemplates/tree/main/v1/src/main/java/com/google/cloud/teleport/spanner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1315544255
I don't think we should proliferate the use of ValueProviders. People can use FlexTemplates instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1315408144
Do we need valueproviders? My understanding is that they were only necessary for classic templates, and that new templates would be flextemplates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #24156:
URL: https://github.com/apache/beam/pull/24156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1313770133
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
bvolpato commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1314459076
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1314459965
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #24156: Use only ValueProviders in SpannerConfig
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #24156:
URL: https://github.com/apache/beam/pull/24156#issuecomment-1317177121
> We have a couple of Legacy/Classic templates for Spanner [1]. I agree on new templates being Flex, that's a route we want to pursue, including migrating classic to Flex when feasible. With this change in specific, we have some inheritance from Beam that requires some rework, so I am trying to keep it consistent.
>
> Not changing to a ValueProvider would mean that we can only configure a subset of the parameters (or at this time, all but one).
>
> [1] https://github.com/GoogleCloudPlatform/DataflowTemplates/tree/main/v1/src/main/java/com/google/cloud/teleport/spanner
got it. If we are already using this for classic templates, we should keep it consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org