You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2023/01/20 01:25:13 UTC
[GitHub] [incubator-streampark] RocMarshal opened a new pull request, #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
RocMarshal opened a new pull request, #2263:
URL: https://github.com/apache/incubator-streampark/pull/2263
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
[Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #2263:
URL: https://github.com/apache/incubator-streampark/pull/2263#discussion_r1082593054
##########
.gitignore:
##########
@@ -42,3 +42,4 @@ hs_err_pid*
*.tar.gz
*.rar
*Spec-output/
+streampark-console/streampark-console-webapp/node/
Review Comment:
how about `*/node` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2263:
URL: https://github.com/apache/incubator-streampark/pull/2263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] RocMarshal closed pull request #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
Posted by GitBox <gi...@apache.org>.
RocMarshal closed pull request #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
URL: https://github.com/apache/incubator-streampark/pull/2263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] RocMarshal commented on a diff in pull request #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #2263:
URL: https://github.com/apache/incubator-streampark/pull/2263#discussion_r1083225470
##########
.gitignore:
##########
@@ -42,3 +42,4 @@ hs_err_pid*
*.tar.gz
*.rar
*Spec-output/
+streampark-console/streampark-console-webapp/node/
Review Comment:
**/node?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] RocMarshal commented on a diff in pull request #2263: [Hotfix] Add 'streampark-console/streampark-console-webapp/node/' relative path into .gitignore file.
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #2263:
URL: https://github.com/apache/incubator-streampark/pull/2263#discussion_r1083225470
##########
.gitignore:
##########
@@ -42,3 +42,4 @@ hs_err_pid*
*.tar.gz
*.rar
*Spec-output/
+streampark-console/streampark-console-webapp/node/
Review Comment:
I guess you might want to express this meaning more ？ `**/node`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org