You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/07 20:49:05 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4688: Added notes about management interfaces and checking for valid data
ocket8888 opened a new pull request #4688:
URL: https://github.com/apache/trafficcontrol/pull/4688
## What does this PR (Pull Request) do?
- [x] This PR is not related to any Issue
This PR adds some notes to the multiple server interfaces. Since "management" IP address/gateway/netmask fields are totally unvalidated in today's ATC setups, they can contain bad data. So instead of converting existing data into the new structure automatically and deleting those fields, we should push that to a later date and give operators of CDNs with invalid IP addresses in those fields time to convert manually to avoid data loss.
This also notes a previously unexpected upgrade impact, as not all of the various IP/IPv6 address/gateway/netmask fields are validated today, and none are bound to have any particular format when stored in the database. As a result, problematic data will need to be manually fixed prior to an upgrade containing this feature. For specifics on what constitutes "problematic" data, consult the blueprint.
## Which Traffic Control components are affected by this PR?
None
## What is the best way to verify this PR?
Read the blueprint.
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 merged pull request #4688: Added notes about management interfaces and checking for valid data
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4688:
URL: https://github.com/apache/trafficcontrol/pull/4688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org