[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #224: [YUNIKORN-518] Placeholder manager failed to init during scheduler recovery

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #224:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/224#issuecomment-768793771


   hi @wilfred-s the purpose of adding that FATAL error is to make sure we can crash the scheduler when placeholder manager was not initialized. And the reason we hit this issue was that the `NewPlaceholderManager()` was not called after `GetPlaceholderManager()` during recovery, so it crashed. This should never happen in production. If we remove that and we will get an NPE here, similar but with the FATAL error, we know definitely something goes wrong.
   
   We can check the return value of `NewPlaceholderManager()` but that's really not the root cause. The fix is to adjust the order of services' starting to make sure the `NewPlaceholderManager()` gets called before `GetPlaceholderManager()`.
   
   Does that make sense?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org