You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/09 14:20:45 UTC
[GitHub] [flink] GJL commented on a change in pull request #9637:
[FLINK-13884] Set default delay for restart strategies to 1s
GJL commented on a change in pull request #9637: [FLINK-13884] Set default delay for restart strategies to 1s
URL: https://github.com/apache/flink/pull/9637#discussion_r322269347
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
##########
@@ -92,12 +91,9 @@ public String toString() {
public static FailureRateRestartStrategyFactory createFactory(Configuration configuration) throws Exception {
int maxFailuresPerInterval = configuration.getInteger(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_MAX_FAILURES_PER_INTERVAL);
- String failuresIntervalString = configuration.getString(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL);
- String timeoutString = configuration.getString(AkkaOptions.WATCH_HEARTBEAT_INTERVAL);
Review comment:
Valid point. What is the justification for not falling back to `WATCH_HEARTBEAT_INTERVAL` anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services