Re: svn commit: r638369 - in /stdcxx/trunk/include: loc/_num_get.cc loc/_num_get.h rw/_iosfwd.h

[Martin Sebor <se...@roguewave.com>]

faridz@apache.org wrote:
> Author: faridz
> Date: Tue Mar 18 07:09:17 2008
> New Revision: 638369
> 
[...]
> Modified: stdcxx/trunk/include/loc/_num_get.h
> URL: http://svn.apache.org/viewvc/stdcxx/trunk/include/loc/_num_get.h?rev=638369&r1=638368&r2=638369&view=diff
> ==============================================================================
> --- stdcxx/trunk/include/loc/_num_get.h (original)
> +++ stdcxx/trunk/include/loc/_num_get.h Tue Mar 18 07:09:17 2008
> @@ -259,6 +259,87 @@
[...]
> +    else if (__lval > __int_max) {
> +        __err |= _RW::__rw_failbit;
> +        return = int (_RWSTD_INT_MAX);
            ^^^^^^^^^^^^

This looks like a typo (I'm getting a build error).

Martin

RE: svn commit: r638369 - in /stdcxx/trunk/include: loc/_num_get.cc loc/_num_get.h rw/_iosfwd.h

[Farid Zaripov <Fa...@epam.com>]

> -----Original Message-----
> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor
> Sent: Tuesday, March 18, 2008 6:12 PM
> To: dev@stdcxx.apache.org
> Subject: Re: svn commit: r638369 - in /stdcxx/trunk/include: 
> loc/_num_get.cc loc/_num_get.h rw/_iosfwd.h
> 
> > +        return = int (_RWSTD_INT_MAX);
>             ^^^^^^^^^^^^
> 
> This looks like a typo (I'm getting a build error).

  I've tested the patched sources on MSVC and gcc/linux and
didn't found this bug due to _RWSTD_INT_MAX == _RWSTD_LONG_MAX
on these compilers.

  Fixed: http://svn.apache.org/viewvc?rev=638433&view=rev

Farid.