[GitHub] [iceberg] zhengzengprc commented on a change in pull request #3039: Introduce spark3 option to read stream from a timestamp

[GitBox <gi...@apache.org>]

zhengzengprc commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r699759948



##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -65,12 +65,16 @@ public static boolean ancestorOf(Table table, long snapshotId, long ancestorSnap
   }
 
   /**
-   * Traverses the history of the table's current snapshot and finds the oldest Snapshot.
-   * @return null if there is no current snapshot in the table, else the oldest Snapshot.
+   * Traverses the history of the table's current snapshot and finds the oldest Snapshot after the timestamp.
+   * @return null if there is no current snapshot in the table, else the oldest Snapshot after the timestamp.

Review comment:
       Thanks for the comment we will add the milliseconds in the documentation as suggested
   oldestSnapshot will grab the snapshot that is oldest which just crosses the timestamp.
   Let's take an example with the assumption
   Snapshot with time series: 10,20,30,40,50
   Current snapshot will be with timestamp 50
   The input timestamp is 31.
   So the return snapshot will return with timestamp 40 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org