You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2022/04/04 08:12:10 UTC
[superset] 10/23: chore: Removes hard-coded colors from legacy-preset-chart-nvd3 (#19443)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to tag 1.5.0rc1
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 91bf9bd68b9c402ef68e538f86f5d9283f281688
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Thu Mar 31 13:29:54 2022 -0300
chore: Removes hard-coded colors from legacy-preset-chart-nvd3 (#19443)
(cherry picked from commit 47abad867355f45bc369d6e7e59f3b7f1f9d02ca)
---
.../plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx
index 507cc60fe6..9a9962e8aa 100644
--- a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx
+++ b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx
@@ -63,7 +63,7 @@ export default styled(NVD3)`
}
.nvtooltip tr.highlight td {
font-weight: ${({ theme }) => theme.typography.weights.bold};
- font-size: 15px !important;
+ font-size: ${({ theme }) => theme.typography.sizes.m}px !important;
}
text.nv-axislabel {
font-size: ${({ theme }) => theme.typography.sizes.m} !important;
@@ -160,15 +160,15 @@ export default styled(NVD3)`
.d3-tip.nv-event-annotation-layer-NATIVE {
width: 200px;
border-radius: 2px;
- background-color: #484848;
+ background-color: ${({ theme }) => theme.colors.grayscale.base};
fill-opacity: 0.6;
- margin: 8px;
- padding: 8px;
- color: #fff;
+ margin: ${({ theme }) => theme.gridUnit * 2}px;
+ padding: ${({ theme }) => theme.gridUnit * 2}px;
+ color: ${({ theme }) => theme.colors.grayscale.light5};
&:after {
content: '\\25BC';
font-size: ${({ theme }) => theme.typography.sizes.m};
- color: #484848;
+ color: ${({ theme }) => theme.colors.grayscale.base};
position: absolute;
bottom: -14px;
left: 94px;