You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "horizonzy (via GitHub)" <gi...@apache.org> on 2023/10/07 03:58:34 UTC
[PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
horizonzy opened a new pull request, #21310:
URL: https://github.com/apache/pulsar/pull/21310
Fixes #21286, #21289
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1754618781
> This will help reduce flakiness a lot. Please cherry-pick also to branch-3.1 since that will be maintained for some time.
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751590058
@horizonzy Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1752001954
Great work @horizonzy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #21310: [fix] [metadata] Fix zookeeper related flacky test
URL: https://github.com/apache/pulsar/pull/21310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode merged PR #21310:
URL: https://github.com/apache/pulsar/pull/21310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1756729122
> This will help reduce flakiness a lot. Please cherry-pick also to branch-3.1 since that will be maintained for some time.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751920845
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1753237010
This will help reduce flakiness a lot. Please cherry-pick also to branch-3.1 since that will be maintained for some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751928637
@hangc0276 @Technoboy- @poorbarcode Please help to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751924440
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21310](https://app.codecov.io/gh/apache/pulsar/pull/21310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0e3a69) into [master](https://app.codecov.io/gh/apache/pulsar/commit/643428bb295ee4781e86aa2c72e5ad5d61b98870?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (643428b) will **increase** coverage by `36.28%`.
> Report is 5 commits behind head on master.
> The diff coverage is `100.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21310 +/- ##
=============================================
+ Coverage 36.96% 73.24% +36.28%
- Complexity 12294 32521 +20227
=============================================
Files 1698 1887 +189
Lines 130510 140223 +9713
Branches 14260 15435 +1175
=============================================
+ Hits 48240 102709 +54469
+ Misses 75982 29436 -46546
- Partials 6288 8078 +1790
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21310/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.13% <66.66%> (-0.19%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.70% <66.66%> (-0.19%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.54% <100.00%> (+40.41%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/21310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/bookkeeper/mledger/util/RangeCache.java](https://app.codecov.io/gh/apache/pulsar/pull/21310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci91dGlsL1JhbmdlQ2FjaGUuamF2YQ==) | `95.40% <100.00%> (+21.53%)` | :arrow_up: |
... and [1452 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21310/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy closed pull request #21310: [fix] [metadata] Fix zookeeper related flacky test
URL: https://github.com/apache/pulsar/pull/21310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #21310:
URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751958004
Since the PR https://github.com/apache/pulsar/pull/21188 will cherry-pick into `branch-3.0`, `branch-2.11` and `branch-2.10` and the test is very flaky, I added the labels `release/2.10.6`, `release/2.11.3` and `release/3.0.2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org