You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/29 18:45:26 UTC
[GitHub] [arrow] jvictorhuguenin opened a new pull request #10622: ARROW-13213: Implement parse_url hive function
jvictorhuguenin opened a new pull request #10622:
URL: https://github.com/apache/arrow/pull/10622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10622: ARROW-13213: [C++][Gandiva] Implement parse_url hive function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10622:
URL: https://github.com/apache/arrow/pull/10622#issuecomment-979144430
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvictorhuguenin commented on pull request #10622: ARROW-13213: Implement parse_url hive function
Posted by GitBox <gi...@apache.org>.
jvictorhuguenin commented on pull request #10622:
URL: https://github.com/apache/arrow/pull/10622#issuecomment-870837951
@jpedroantunes, can you review this PR, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jpedroantunes commented on a change in pull request #10622: ARROW-13213: Implement parse_url hive function
Posted by GitBox <gi...@apache.org>.
jpedroantunes commented on a change in pull request #10622:
URL: https://github.com/apache/arrow/pull/10622#discussion_r661055443
##########
File path: cpp/src/gandiva/precompiled/string_ops.cc
##########
@@ -1966,4 +1966,233 @@ const char* binary_string(gdv_int64 context, const char* text, gdv_int32 text_le
*out_len = j;
return ret;
}
+
+FORCE_INLINE
+const char* parse_url_utf8_utf8(gdv_int64 context, const char* url, gdv_int64 url_len,
+ const char* part_to_extract, gdv_int64 part_len,
+ gdv_int32* out_len) {
+ if (url_len == 0) {
+ return nullptr;
+ }
+
+ auto protocol_key = "PROTOCOL";
Review comment:
Maybe we can check a way of not having to instantiate these variables constantly.
##########
File path: cpp/src/gandiva/precompiled/string_ops_test.cc
##########
@@ -1540,4 +1540,72 @@ TEST(TestStringOps, TestConvertToBigEndian) {
}
#endif
}
+
Review comment:
Add prijector tests please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10622: ARROW-13213: Implement parse_url hive function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10622:
URL: https://github.com/apache/arrow/pull/10622#issuecomment-870830578
https://issues.apache.org/jira/browse/ARROW-13213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10622: ARROW-13213: [C++][Gandiva] Implement parse_url hive function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10622:
URL: https://github.com/apache/arrow/pull/10622#issuecomment-979144422
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org