[jira] Issue Comment Edited: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly

["Hiram Chirino (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616954#action_12616954 ] 

chirino edited comment on ZOOKEEPER-82 at 7/25/08 10:13 AM:
------------------------------------------------------------------

Weird the patch did not change QuorumPeer at all.  QuorumPeer did not currently have a main method. Seem someone else moved it to ManagedQuorumPeer.  But in my next patch I'll move those java docs and update the scripts.

Yes main was moved from ZooKeeperServer to new class which my patch failed to include.  Sorry I'll to a attach a new patch asap. Will also add some doco for the getters/setters.

 

      was (Author: chirino):
    Weird the patch did not change QuorumPeer at all.  QuorumPeer did not currently have a main method. Seem someone else moved it to ManagedQuorumPeer.  But in my next patch I'll move those java docs and update the scripts.

Yes main was moved from ZooKeeperServer to new class which my patch failed to include.  Sorry I'll to a attach a new patch asap. Will also add some doco for the getters/setters.

BTW 

 
  
> Make the ZooKeeperServer more DI friendly
> -----------------------------------------
>
>                 Key: ZOOKEEPER-82
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>         Attachments: ZOOKEEPER-82.patch
>
>
> Proposed changes were discussed in [this mailing list thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/%3Caf2843cd0807180907v44b310bg232be99ac0b47a27@mail.gmail.com%3E]:
> Basic goals are: 
> * Decouple the current configuration system from the public API.  I
> see stuff like ZooKeeperServer being coupled to ServerConfig a bit.
> * Allow the use of setter injection in addition to constructor
> injection. This is the most important thing needed to let spring more
> easily configure the objects.
> * Move the main() methods out of the ZooKeeperServer class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.