You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2026/05/05 09:01:23 UTC
[PR] Routed: get vm network statistics on Routed network [cloudstack]
weizhouapache opened a new pull request, #13105:
URL: https://github.com/apache/cloudstack/pull/13105
### Description
This PR fixes #11299
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5568874812
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#discussion_r3200701183
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -2139,6 +2147,27 @@ protected boolean isCurrentVmDiskStatsDifferentFromPrevious(VmDiskStatisticsVO p
return true;
}
+ /**
+ * Returns {@code true} if the given network is eligible for VM network statistics collection.
+ * Only Shared (DirectAttached) networks and Routed networks qualify.
+ *
+ * @param networkId the network id to evaluate
+ * @return {@code true} when the network is routed or direct-attached, {@code false} otherwise
+ */
+ protected boolean isNetworkEligibleForNetworkStats(Long networkId) {
+ if (networkId == null) {
+ return false;
+ }
+ List<VlanVO> vlans = _vlanDao.listVlansByNetworkId(networkId);
+ boolean isDirectAttachedNetwork = CollectionUtils.isNotEmpty(vlans)
+ && vlans.get(0).getVlanType() == VlanType.DirectAttached;
+ if (isDirectAttachedNetwork) {
+ return true;
+ }
+ NetworkVO networkVO = networkDao.findById(networkId);
+ return networkVO != null && routedIpv4Manager.isRoutedNetwork(networkVO);
+ }
+
Review Comment:
This helper is called inside the innermost VM/NIC stats loop, but it performs multiple DB lookups (`networkDao.findById` here and `routedIpv4Manager.isRoutedNetwork(...)`, which in `RoutedIpv4ManagerImpl` loads the network offering). This can create an N+1 query pattern on large setups. Consider caching eligibility per `networkId` for the duration of the task/transaction or otherwise batching/preloading the network/offering data to avoid repeated queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5570844003
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4377917481
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13105?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.69%. Comparing base ([`5b9a3d7`](https://app.codecov.io/gh/apache/cloudstack/commit/5b9a3d7d320e2dd5bf58d517007d80ce347d89a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6501879`](https://app.codecov.io/gh/apache/cloudstack/commit/6501879e08bfe7d645c5785c756a7c8bc0b4899c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (5b9a3d7) and HEAD (6501879). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (5b9a3d7) | HEAD (6501879) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.22 #13105 +/- ##
=============================================
- Coverage 17.67% 3.69% -13.99%
=============================================
Files 5922 448 -5474
Lines 533085 38101 -494984
Branches 65205 7059 -58146
=============================================
- Hits 94243 1409 -92834
+ Misses 428204 36505 -391699
+ Partials 10638 187 -10451
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13105/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13105/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.69% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13105/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/13105?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4396031832
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4379150237
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#discussion_r3187573817
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1582,8 +1590,11 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
sc_nic.addAnd("macAddress", SearchCriteria.Op.EQ, vmNetworkStatEntry.getMacAddress());
NicVO nic = _nicDao.search(sc_nic, null).get(0);
List<VlanVO> vlan = _vlanDao.listVlansByNetworkId(nic.getNetworkId());
- if (vlan == null || vlan.size() == 0 || vlan.get(0).getVlanType() != VlanType.DirectAttached)
- continue; // only get network statistics for DirectAttached network (shared networks in Basic zone and Advanced zone with/without SG)
+ NetworkVO networkVO = networkDao.findById(nic.getNetworkId());
+ if (CollectionUtils.isEmpty(vlan) || (vlan.get(0).getVlanType() != VlanType.DirectAttached
+ && (networkVO == null || !routedIpv4Manager.isRoutedNetwork(networkVO)))) {
Review Comment:
The new filter still skips statistics collection when `listVlansByNetworkId(...)` returns empty, even if the NIC’s network is a routed network. Routed guest networks get their CIDR/subnet via `RoutedIpv4Manager`/`Ipv4GuestSubnetNetworkMap` (not via `vlan` table), so this `CollectionUtils.isEmpty(vlan)` guard can prevent routed networks from ever reaching the `isRoutedNetwork` check. Consider restructuring the condition to treat routed networks as eligible regardless of VLAN list presence (e.g., check `isRoutedNetwork` first, and only enforce the VLAN/DirectAttached requirement for non-routed networks).
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1582,8 +1590,11 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
sc_nic.addAnd("macAddress", SearchCriteria.Op.EQ, vmNetworkStatEntry.getMacAddress());
NicVO nic = _nicDao.search(sc_nic, null).get(0);
List<VlanVO> vlan = _vlanDao.listVlansByNetworkId(nic.getNetworkId());
- if (vlan == null || vlan.size() == 0 || vlan.get(0).getVlanType() != VlanType.DirectAttached)
- continue; // only get network statistics for DirectAttached network (shared networks in Basic zone and Advanced zone with/without SG)
+ NetworkVO networkVO = networkDao.findById(nic.getNetworkId());
+ if (CollectionUtils.isEmpty(vlan) || (vlan.get(0).getVlanType() != VlanType.DirectAttached
+ && (networkVO == null || !routedIpv4Manager.isRoutedNetwork(networkVO)))) {
Review Comment:
This change introduces new behavior around routed networks in the VM network stats collection path, but there are no unit tests covering the acceptance/rejection logic for routed vs shared networks. Since `StatsCollectorTest` exists for this class, it would be good to add tests that exercise the VLAN-type/routed-network branching to prevent regressions (including the case where routed networks have no VLAN records).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4379651857
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5570817185
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5568884874
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5569614968
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4396021700
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala merged PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5556137724
This PR is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4402103553
<b>[SF] Trillian test result (tid-16037)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13105-t16037-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_redundant_vpc_site2site_vpn | `Failure` | 367.42 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-4379163309
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#discussion_r3195394940
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1582,8 +1590,13 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
sc_nic.addAnd("macAddress", SearchCriteria.Op.EQ, vmNetworkStatEntry.getMacAddress());
NicVO nic = _nicDao.search(sc_nic, null).get(0);
List<VlanVO> vlan = _vlanDao.listVlansByNetworkId(nic.getNetworkId());
- if (vlan == null || vlan.size() == 0 || vlan.get(0).getVlanType() != VlanType.DirectAttached)
- continue; // only get network statistics for DirectAttached network (shared networks in Basic zone and Advanced zone with/without SG)
+ NetworkVO networkVO = networkDao.findById(nic.getNetworkId());
+ boolean isRoutedNetwork = networkVO != null && routedIpv4Manager.isRoutedNetwork(networkVO);
+ boolean isDirectAttachedNetwork = CollectionUtils.isNotEmpty(vlan)
+ && vlan.get(0).getVlanType() == VlanType.DirectAttached;
Review Comment:
This loop now does multiple DB lookups per NIC/stat entry (listVlansByNetworkId + networkDao.findById + isRoutedNetwork() which itself consults the offering DAO). In large deployments this can become a hot path during periodic stats collection. Consider caching per-networkId (e.g., Map<Long,Boolean> routed/directAttached) within the task run/transaction and short-circuiting the VLAN query for routed networks (check routed first; only query VLANs when not routed).
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1582,8 +1590,13 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
sc_nic.addAnd("macAddress", SearchCriteria.Op.EQ, vmNetworkStatEntry.getMacAddress());
NicVO nic = _nicDao.search(sc_nic, null).get(0);
List<VlanVO> vlan = _vlanDao.listVlansByNetworkId(nic.getNetworkId());
- if (vlan == null || vlan.size() == 0 || vlan.get(0).getVlanType() != VlanType.DirectAttached)
- continue; // only get network statistics for DirectAttached network (shared networks in Basic zone and Advanced zone with/without SG)
+ NetworkVO networkVO = networkDao.findById(nic.getNetworkId());
+ boolean isRoutedNetwork = networkVO != null && routedIpv4Manager.isRoutedNetwork(networkVO);
+ boolean isDirectAttachedNetwork = CollectionUtils.isNotEmpty(vlan)
+ && vlan.get(0).getVlanType() == VlanType.DirectAttached;
+ if (!isRoutedNetwork && !isDirectAttachedNetwork) {
+ continue; // only get network statistics for Shared or Routed network
+ }
Review Comment:
The routed-network filtering logic is newly introduced here but doesn’t appear to be covered by existing unit tests for StatsCollector. Please add a focused test (mocking NetworkDao/RoutedIpv4Manager/VlanDao and a NIC) to verify that routed networks are included, and that non-direct-attached, non-routed networks are skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Routed: get vm network statistics on Routed network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13105:
URL: https://github.com/apache/cloudstack/pull/13105#issuecomment-5579728128
<b>[SF] Trillian test result (tid-16919)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55973 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13105-t16919-kvm-ol8.zip
Smoke tests completed. 147 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_enableHumanReadableLogs | `Error` | 0.30 | test_human_readable_logs.py
test_01_browser_migrate_template | `Error` | 66.03 | test_image_store_object_migration.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org