You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2017/12/15 21:25:00 UTC

[jira] [Closed] (HTTPCORE-501) org.apache.hc.core5.net.URLEncodedUtils.parse() should return a new ArrayList when there are no query parameters

     [ https://issues.apache.org/jira/browse/HTTPCORE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory closed HTTPCORE-501.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 5.0-beta2

In git master.

> org.apache.hc.core5.net.URLEncodedUtils.parse() should return a new ArrayList when there are no query parameters
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-501
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-501
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 5.0-beta1
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 5.0-beta2
>
>
> {{org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset)}} should return a new {{ArrayList}} when there are no query parameters.
> Currently, {{org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset)}} returns an immutable list through {{Collections.emptyList()}} if there are no params> But if there are parameters, the method returns a mutable list.
> This makes it impossible to write the same code to handle both cases.
> This change will cause the method to return a new {{ArrayList}} if there are no parameters.
> The methods that are directly affected are:
> - org.apache.hc.core5.net.URLEncodedUtils.parse(String, Charset, char...)
> - org.apache.hc.core5.net.URLEncodedUtils.parse(String, Charset)
> - org.apache.hc.core5.net.URLEncodedUtils.parse(URI, Charset)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org