You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jay Kreps (JIRA)" <ji...@apache.org> on 2012/09/14 23:14:08 UTC

[jira] [Created] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

Jay Kreps created KAFKA-516:
-------------------------------

             Summary: Consider catching all exceptions in ShutdownableThread
                 Key: KAFKA-516
                 URL: https://issues.apache.org/jira/browse/KAFKA-516
             Project: Kafka
          Issue Type: Bug
            Reporter: Jay Kreps


I don't think there is any case where we want an uncaught exception to kill the thread. In fact this can be a bit hard to debug if an important background thread disappears. We should consider catching everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao closed KAFKA-516.
-------------------------

    
> Consider catching all exceptions in ShutdownableThread
> ------------------------------------------------------
>
>                 Key: KAFKA-516
>                 URL: https://issues.apache.org/jira/browse/KAFKA-516
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>              Labels: bugs
>             Fix For: 0.8
>
>
> I don't think there is any case where we want an uncaught exception to kill the thread. In fact this can be a bit hard to debug if an important background thread disappears. We should consider catching everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Koshy updated KAFKA-516:
-----------------------------

    Affects Version/s: 0.8
        Fix Version/s: 0.8
    
> Consider catching all exceptions in ShutdownableThread
> ------------------------------------------------------
>
>                 Key: KAFKA-516
>                 URL: https://issues.apache.org/jira/browse/KAFKA-516
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>             Fix For: 0.8
>
>
> I don't think there is any case where we want an uncaught exception to kill the thread. In fact this can be a bit hard to debug if an important background thread disappears. We should consider catching everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Koshy updated KAFKA-516:
-----------------------------

    Labels: bugs  (was: )
    
> Consider catching all exceptions in ShutdownableThread
> ------------------------------------------------------
>
>                 Key: KAFKA-516
>                 URL: https://issues.apache.org/jira/browse/KAFKA-516
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>              Labels: bugs
>             Fix For: 0.8
>
>
> I don't think there is any case where we want an uncaught exception to kill the thread. In fact this can be a bit hard to debug if an important background thread disappears. We should consider catching everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yang Ye resolved KAFKA-516.
---------------------------

    Resolution: Fixed
    
> Consider catching all exceptions in ShutdownableThread
> ------------------------------------------------------
>
>                 Key: KAFKA-516
>                 URL: https://issues.apache.org/jira/browse/KAFKA-516
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>              Labels: bugs
>             Fix For: 0.8
>
>
> I don't think there is any case where we want an uncaught exception to kill the thread. In fact this can be a bit hard to debug if an important background thread disappears. We should consider catching everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471872#comment-13471872 ] 

Yang Ye commented on KAFKA-516:
-------------------------------


In ShutdownableThread , all exceptions are actually caught. 
                
> Consider catching all exceptions in ShutdownableThread
> ------------------------------------------------------
>
>                 Key: KAFKA-516
>                 URL: https://issues.apache.org/jira/browse/KAFKA-516
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>              Labels: bugs
>             Fix For: 0.8
>
>
> I don't think there is any case where we want an uncaught exception to kill the thread. In fact this can be a bit hard to debug if an important background thread disappears. We should consider catching everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira