[GitHub] [incubator-yunikorn-k8shim] manirajv06 commented on a change in pull request #380: [YUNIKORN-1090] remove common.Node from the shim

[GitBox <gi...@apache.org>]

manirajv06 commented on a change in pull request #380:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/380#discussion_r823379317



##########
File path: pkg/common/si_helper.go
##########
@@ -177,14 +184,11 @@ func CreateUpdateRequestForUpdatedNode(node Node) si.NodeRequest {
 	return request
 }
 
-func CreateUpdateRequestForDeleteNode(node Node) si.NodeRequest {
+func CreateUpdateRequestForDeleteNode(nodeID string, action si.NodeInfo_ActionFromRM) si.NodeRequest {

Review comment:
       "delete" as generic term for drain or decommission, but it does restore as well. hence named it as DeleteOrRestore. Hope this is ok.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org