[GitHub] [doris] jackwener opened a new pull request, #10679: [feature](Nereids): hashCode(), equals() and UT.

[GitBox <gi...@apache.org>]

jackwener opened a new pull request, #10679:
URL: https://github.com/apache/doris/pull/10679

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Add hashCode(), equals() for operator.
   
   Add basic UT for them(need more detail test).
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: no
   2. Has unit tests been added: no need
   3. Has document been added or modified: no need
   4. Does it need to update dependencies: no
   5. Are there any changes that cannot be rolled back: no
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] jackwener closed pull request #10679: [feature](Nereids): hashCode(), equals() and UT for operator.

[GitBox <gi...@apache.org>]

jackwener closed pull request #10679: [feature](Nereids): hashCode(), equals() and UT for operator.
URL: https://github.com/apache/doris/pull/10679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow commented on a diff in pull request #10679: [feature](Nereids): hashCode(), equals() and UT.

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #10679:
URL: https://github.com/apache/doris/pull/10679#discussion_r915822237


##########
fe/fe-core/src/test/java/org/apache/doris/nereids/operators/EqualsTest.java:
##########
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.operators;
+
+import org.apache.doris.catalog.Table;
+import org.apache.doris.catalog.TableIf.TableType;
+import org.apache.doris.nereids.operators.plans.JoinType;
+import org.apache.doris.nereids.operators.plans.logical.LogicalAggregate;
+import org.apache.doris.nereids.operators.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.operators.plans.logical.LogicalJoin;
+import org.apache.doris.nereids.operators.plans.logical.LogicalOlapScan;
+import org.apache.doris.nereids.operators.plans.logical.LogicalProject;
+import org.apache.doris.nereids.operators.plans.logical.LogicalSort;
+import org.apache.doris.nereids.properties.OrderKey;
+import org.apache.doris.nereids.trees.expressions.EqualTo;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.Literal;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.types.BigIntType;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Lists;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.List;
+
+public class EqualsTest {
+    @Test
+    public void testLogicalAggregate() {
+        List<Expression> groupByExprList = Lists.newArrayList();
+        SlotReference slotReference = new SlotReference("a", new BigIntType(), true, Lists.newArrayList());
+        List<NamedExpression> outputExpressionList = ImmutableList.of(slotReference);
+
+        LogicalAggregate logicalAggregate = new LogicalAggregate(groupByExprList, outputExpressionList);
+        Assert.assertEquals(logicalAggregate, logicalAggregate);

Review Comment:
   we need two different object to do test. because same object is only cover case 'a == b'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org