[GitHub] [cordova-plugin-geolocation] breautek edited a comment on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS

[GitBox <gi...@apache.org>]

breautek edited a comment on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS
URL: https://github.com/apache/cordova-plugin-geolocation/pull/171#issuecomment-571162438
 
 
   > This is nice, would fix #187 nicely, however default `false` would be even better
   
   Defaulting to `false` would be a breaking change.
   
   To keep consistency with other plugins, I think the preference should be `GeolocationRequired` instead of `ANDROID_GPS_REQUIRED`. (You can see [StatusBar preferences](https://github.com/apache/cordova-plugin-statusbar#preferences) as an example.
   
   A note can be made in the documentation that this preference only applies to android.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org