[jira] [Commented] (AIRFLOW-533) DB API hook's insert_rows sets autocommit non-generically

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666397#comment-15666397 ] 

ASF subversion and git services commented on AIRFLOW-533:
---------------------------------------------------------

Commit f34b292f5889a6c155d967d1987e052e0bc92075 in incubator-airflow's branch refs/heads/master from [~lukerohde]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=f34b292 ]

[AIRFLOW-533] Set autocommit via set_autocommit

 Delegate setting autocommit in insert_rows to set_autocommit

Closes #1813 from thyming/fix-insert-rows-
autocommit


> DB API hook's insert_rows sets autocommit non-generically
> ---------------------------------------------------------
>
>                 Key: AIRFLOW-533
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-533
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>            Reporter: Luke Rohde
>            Assignee: Luke Rohde
>
> The DB API hook has different behavior between 
> https://github.com/apache/incubator-airflow/blob/189e6b88742ace8c46e72d59d7662284e34b7a2e/airflow/hooks/dbapi_hook.py#L189
> and
> https://github.com/apache/incubator-airflow/blob/189e6b88742ace8c46e72d59d7662284e34b7a2e/airflow/hooks/dbapi_hook.py#L142
> in how it handles autocommit. The latter seems correct to me, as it delegates to the implementation how to set autocommit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)