You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by osma <gi...@git.apache.org> on 2015/10/29 16:15:33 UTC
[GitHub] jena pull request: JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer...
GitHub user osma opened a pull request:
https://github.com/apache/jena/pull/96
JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer for jena-text
See https://issues.apache.org/jira/browse/JENA-1058
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/osma/jena jena-text-folding-analyzer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit f176e150bcd1161afda5f6ba52aef678127b7464
Author: Osma Suominen <os...@aalto.fi>
Date: 2015-10-29T15:08:54Z
first implementation of ASCIIFoldingLowerCaseKeywordAnalyzer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/96#issuecomment-152551219
+1 : Looks good
By the way - is there documentation (i.e. a list) of all the analyzers we have?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer...
Posted by osma <gi...@git.apache.org>.
Github user osma closed the pull request at:
https://github.com/apache/jena/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer...
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/96#issuecomment-152983824
@afs Yes there is, in the jena-text documentation, though calling it a list is a bit of a stretch since there are only four currently (StandardAnalyzer, SimpleAnalyzer, KeywordAnalyzer and LowerCaseKeywordAnalyzer) and only LowerCaseKeywordAnalyzer is specific to jena-text, the other three come directly from Lucene.
See https://jena.apache.org/documentation/query/text-query.html#configuring-an-analyzer
About this PR: I think I will try to implement a more generic, configurable analyzer, as suggested by Claude Warren in a comment on JIRA-1058. If it's not too difficult, it would obviously be better than this very specific analyzer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer...
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/96#issuecomment-153977494
I drop this in favor of JENA-1062 / PR #97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1058: ASCIIFoldingLowerCaseKeywordAnalyzer...
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/96#issuecomment-152211292
The class names are getting ridiculously long, but I just followed the same pattern as before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---