You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "kunwp1 (via GitHub)" <gi...@apache.org> on 2026/07/04 17:45:43 UTC
[PR] feat(frontend): advanced settings for computing-unit creation [texera]
kunwp1 opened a new pull request, #6104:
URL: https://github.com/apache/texera/pull/6104
### What changes were proposed in this PR?
While testing the dknet-ai.org deployment (a downstream fork of Texera), we found the computing-unit creation modal complicated for non-technical users: every configuration is listed inline, and shared memory size / JVM memory size are too technical for most users, crowding the common path (name / RAM / CPU).
This PR tucks those two knobs behind a collapsed "Advanced Settings" disclosure in the shared `ComputingUnitCreateModalComponent` (introduced by #6082), so both creation entry points — the dashboard Computing Units page and the workspace power button — get the simplified default view.
- Progressive disclosure: rotating chevron + smooth height animation (0fr→1fr grid-row transition, no hard-coded max-height); collapsed by default, and re-collapsed every time the modal opens (`ngOnChanges` on `visible`).
- Validation stays visible: when the panel is collapsed and shared memory exceeds total memory, an amber "Shared memory exceeds total" hint is promoted onto the collapsed header so an invalid value cannot be submitted unseen; when valid, the header shows a "Shared memory · JVM heap size" hint to keep the options discoverable.
- Accessibility: the toggle is a native `<button>` with `aria-expanded`, and the collapsed panel is `inert` so its controls stay out of the tab order.
This feature was originally implemented and validated on the downstream deployment ([Texera/dknet-ai-public@30318e2d](https://github.com/Texera/dknet-ai-public/commit/30318e2da47aff5620997febdf2f92e54c92aad1), where the modal was still duplicated across the two hosts) and is re-applied here on top of the shared modal component.
### Any related issues, documentation, discussions?
Closes #6102
### How was this PR tested?
Four unit tests were added to `computing-unit-create-modal.component.spec.ts` covering the panel toggle, the re-collapse-on-open behavior (and that closing does not touch panel state), and the collapsed-header warning in both the shm-too-large and shm-valid cases. Ran the modal suite plus both host suites:
```
cd frontend
yarn test --include "**/computing-unit-create-modal.component.spec.ts" \
--include "**/computing-unit-selection.component.spec.ts" \
--include "**/user-computing-unit.component.spec.ts"
```
All 89 tests pass (3 files). `prettier-eslint --list-different` and `eslint` report no issues on the changed files. The UI behavior (collapsed default, animation, warning promotion, tab order) was validated interactively on the dknet-ai.org deployment where the feature originated.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code, Claude Opus 4.8 (original downstream implementation) and Claude Fable 5 (port onto the shared modal component)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): advanced settings for computing-unit creation [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #6104:
URL: https://github.com/apache/texera/pull/6104#issuecomment-4885186963
/request-review @bobbai00 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): advanced settings for computing-unit creation [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on PR #6104:
URL: https://github.com/apache/texera/pull/6104#issuecomment-4883412340
/request-review @aicam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): advanced settings for computing-unit creation [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6104:
URL: https://github.com/apache/texera/pull/6104#discussion_r3547831145
##########
frontend/src/app/common/component/computing-unit-create-modal/computing-unit-create-modal.component.ts:
##########
@@ -157,6 +161,24 @@ export class ComputingUnitCreateModalComponent implements OnInit {
});
}
+ ngOnChanges(changes: SimpleChanges): void {
+ // Re-collapse the advanced panel every time the modal opens so it always
+ // starts on the simple path (name / RAM / CPU).
+ if (changes["visible"]?.currentValue === true) {
+ this.showAdvancedSettings = false;
+ }
+ }
+
+ toggleAdvancedSettings(): void {
+ this.showAdvancedSettings = !this.showAdvancedSettings;
+ }
+
+ // Surfaces the shared-memory warning on the collapsed header so an invalid
+ // value tucked inside the panel can't be submitted unseen.
+ hasCollapsedWarning(): boolean {
+ return !this.showAdvancedSettings && this.isShmTooLarge();
+ }
Review Comment:
`hasCollapsedWarning()` can show a false warning before resource options load because `selectedMemory` starts as an empty string; `isShmTooLarge()` then compares shm against 0 and returns true. This would make the Advanced Settings header immediately display the warning on first render/open even though the user hasn’t picked/loaded a memory limit yet. Guard on `selectedMemory` being initialized before evaluating the shm check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): advanced settings for computing-unit creation [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 merged PR #6104:
URL: https://github.com/apache/texera/pull/6104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): advanced settings for computing-unit creation [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6104:
URL: https://github.com/apache/texera/pull/6104#issuecomment-4883291504
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6104?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `97.82609%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.10%. Comparing base ([`4c9d30a`](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d95748c`](https://app.codecov.io/gh/apache/texera/commit/d95748cfd7e7a9933656eb2a44964070413a9a50?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/6104?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e-modal/computing-unit-create-modal.component.html](https://app.codecov.io/gh/apache/texera/pull/6104?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fcommon%2Fcomponent%2Fcomputing-unit-create-modal%2Fcomputing-unit-create-modal.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9jb21tb24vY29tcG9uZW50L2NvbXB1dGluZy11bml0LWNyZWF0ZS1tb2RhbC9jb21wdXRpbmctdW5pdC1jcmVhdGUtbW9kYWwuY29tcG9uZW50Lmh0bWw=) | 97.50% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/6104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6104 +/- ##
============================================
- Coverage 59.11% 59.10% -0.02%
Complexity 3197 3197
============================================
Files 1132 1132
Lines 43674 43692 +18
Branches 4734 4736 +2
============================================
+ Hits 25820 25824 +4
- Misses 16420 16435 +15
+ Partials 1434 1433 -1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.08% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.81% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.36% <97.82%> (-0.02%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.15% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [4c9d30a](https://app.codecov.io/gh/apache/texera/commit/4c9d30a132672b9a0e8ecfe1d480a473dae16e4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6104?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): advanced settings for computing-unit creation [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6104:
URL: https://github.com/apache/texera/pull/6104#issuecomment-4883275285
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org