You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2010/12/21 11:45:01 UTC
[jira] Created: (MYFACES-3005) Only send Flash cookie if needed
Only send Flash cookie if needed
--------------------------------
Key: MYFACES-3005
URL: https://issues.apache.org/jira/browse/MYFACES-3005
Project: MyFaces Core
Issue Type: Improvement
Components: JSR-314
Affects Versions: 2.0.3
Reporter: Jakob Korherr
Assignee: Jakob Korherr
As pointed out by Ganesh on the mailing list [1], we do not always have to send the Flash cookie oam.Flash.RENDERMAP.TOKEN (e.g. when there is no data in the Flash scope).
[1] http://old.nabble.com/oam.Flash.RENDERMAP.TOKEN-ts30491897.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-3005) Only send Flash cookie if needed
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ganesh Jung resolved MYFACES-3005.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.5-SNAPSHOT
as discussed on the dev list this is resolved by adding a context param org.apache.myfaces.DISABLE_FLASH_SCOPE (true/false) and throwing a FlashScopeDisabledException in case someone calls one of the public Map acces methods like get, put, keep or putNow
> Only send Flash cookie if needed
> --------------------------------
>
> Key: MYFACES-3005
> URL: https://issues.apache.org/jira/browse/MYFACES-3005
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.3
> Reporter: Jakob Korherr
> Assignee: Ganesh Jung
> Fix For: 2.0.5-SNAPSHOT
>
>
> As pointed out by Ganesh on the mailing list [1], we do not always have to send the Flash cookie oam.Flash.RENDERMAP.TOKEN (e.g. when there is no data in the Flash scope).
> [1] http://old.nabble.com/oam.Flash.RENDERMAP.TOKEN-ts30491897.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-3005) Only send Flash cookie if needed
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974108#action_12974108 ]
Ganesh Jung commented on MYFACES-3005:
--------------------------------------
It's true that users will expect flash scope to work even if they add data during render phase. As JSF managed beans are kind of deprecated in favor of CDI the config param could go one step further and disable JSF managed beans all together. Every Weld developer I've seen has stepped at least once into the Session-Scope-From-Wrong-Package trap and using this new config param (ENABLE_JSF_MANAGED_BEANS->FALSE) any usage of javax.faces.bean.SessionScoped would produce an Exception. The Flash Token would be disabled by this config param too.
> Only send Flash cookie if needed
> --------------------------------
>
> Key: MYFACES-3005
> URL: https://issues.apache.org/jira/browse/MYFACES-3005
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.3
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
>
> As pointed out by Ganesh on the mailing list [1], we do not always have to send the Flash cookie oam.Flash.RENDERMAP.TOKEN (e.g. when there is no data in the Flash scope).
> [1] http://old.nabble.com/oam.Flash.RENDERMAP.TOKEN-ts30491897.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3005) Only send Flash cookie if needed
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973571#action_12973571 ]
Jakob Korherr commented on MYFACES-3005:
----------------------------------------
Checking our FlashImpl, this »might« cause problems, because in theory we should add the cookie as soon as possible to the response (before it is committed), but for this issue we have to wait until the first data is in the render-map and this could be after the response has been committed.
Thus I think we may have to introduce a config parameter saying that all data will be added to the Flash scope before the response is committed, in order to make this improvement. Because otherwise users could run into problems if they are not aware of this fact!
Suggestions are welcome!
> Only send Flash cookie if needed
> --------------------------------
>
> Key: MYFACES-3005
> URL: https://issues.apache.org/jira/browse/MYFACES-3005
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.3
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
>
> As pointed out by Ganesh on the mailing list [1], we do not always have to send the Flash cookie oam.Flash.RENDERMAP.TOKEN (e.g. when there is no data in the Flash scope).
> [1] http://old.nabble.com/oam.Flash.RENDERMAP.TOKEN-ts30491897.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.