You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2016/08/04 16:32:24 UTC

Review Request 50806: ATLAS-1090 : UI: Multi-Select Tagging

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50806/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.


Bugs: ATLAS-1090
    https://issues.apache.org/jira/browse/ATLAS-1090


Repository: atlas


Description
-------

Add assign tag button for multiple tagging in search result table and schema table.


Diffs
-----

  dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 43447d9 
  dashboardv2/public/js/utils/CommonViewFunction.js 79e50b7 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 13896ab 
  dashboardv2/public/js/views/search/SearchLayoutView.js 625f90d 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js b28328c 
  dashboardv2/public/js/views/tag/addTagModalView.js 877c64d 

Diff: https://reviews.apache.org/r/50806/diff/


Testing
-------

** verified following scenario **

* Selected all entity and applied tag for search table and schema table.
* Selected all entity and applied term for search table and schema table.
* Perform sanity testing for UI.


Thanks,

Kalyani Kashikar


Re: Review Request 50806: ATLAS-1090 : UI: Multi-Select Tagging

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50806/#review144895
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 5, 2016, 7:29 a.m., Kalyani Kashikar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50806/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 7:29 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1090
>     https://issues.apache.org/jira/browse/ATLAS-1090
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add assign tag button for multiple tagging in search result table and schema table.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/tag.scss d291cd3 
>   dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 43447d9 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 1ea6189 
>   dashboardv2/public/js/utils/CommonViewFunction.js 79e50b7 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 13896ab 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b28328c 
>   dashboardv2/public/js/views/tag/addTagModalView.js 877c64d 
> 
> Diff: https://reviews.apache.org/r/50806/diff/
> 
> 
> Testing
> -------
> 
> ** verified following scenario **
> 
> * Selected all entity and applied tag for search table and schema table.
> * Selected all entity and applied term for search table and schema table.
> * Perform sanity testing for UI.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>


Re: Review Request 50806: ATLAS-1090 : UI: Multi-Select Tagging

Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50806/
-----------------------------------------------------------

(Updated Aug. 5, 2016, 7:29 a.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.


Changes
-------

Updated patch with new changes.
Added check to Assign Term button in case of business taxonomy.


Bugs: ATLAS-1090
    https://issues.apache.org/jira/browse/ATLAS-1090


Repository: atlas


Description
-------

Add assign tag button for multiple tagging in search result table and schema table.


Diffs (updated)
-----

  dashboardv2/public/css/scss/tag.scss d291cd3 
  dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 43447d9 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 1ea6189 
  dashboardv2/public/js/utils/CommonViewFunction.js 79e50b7 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 13896ab 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js b28328c 
  dashboardv2/public/js/views/tag/addTagModalView.js 877c64d 

Diff: https://reviews.apache.org/r/50806/diff/


Testing
-------

** verified following scenario **

* Selected all entity and applied tag for search table and schema table.
* Selected all entity and applied term for search table and schema table.
* Perform sanity testing for UI.


Thanks,

Kalyani Kashikar