You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/10/28 15:32:02 UTC
[GitHub] [ratis] SzyWilliam opened a new pull request, #771: [RATIS-1733] Typo: fix misleading params names in `RaftServerConfigKeys`
SzyWilliam opened a new pull request, #771:
URL: https://github.com/apache/ratis/pull/771
See https://issues.apache.org/jira/browse/RATIS-1733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #771: RATIS-1733. Typo: fix misleading params names in `RaftServerConfigKeys`
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #771:
URL: https://github.com/apache/ratis/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] SzyWilliam commented on pull request #771: RATIS-1733. Typo: fix misleading params names in `RaftServerConfigKeys`
Posted by GitBox <gi...@apache.org>.
SzyWilliam commented on PR #771:
URL: https://github.com/apache/ratis/pull/771#issuecomment-1297894493
@szetszwo The method `testFollowerLinearizableReadRetryWhenLeaderDown` seems always fail. The error stack is complicated and I found `Caused by: java.io.NotSerializableException: org.apache.ratis.protocol.RaftGroupMemberId`. I suspect that the LeaderNotException returned here [1] contains the RaftGroupMemberId that cannot be serialized. Should we implement 'Serializable` for `RaftGroupMemberId`?
[1] https://github.com/apache/ratis/blob/903cd17c0b0615bfec80afeac796354b9d99a1fd/ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java#L1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #771: RATIS-1733. Typo: fix misleading params names in `RaftServerConfigKeys`
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #771:
URL: https://github.com/apache/ratis/pull/771#issuecomment-1297983587
@SzyWilliam , thanks for
```java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #771: RATIS-1733. Typo: fix misleading params names in `RaftServerConfigKeys`
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #771:
URL: https://github.com/apache/ratis/pull/771#issuecomment-1297262856
@SzyWilliam , TestReadOnlyRequestWithGrpc just have failed in the last build, although it is not related to this change; see https://github.com/apache/ratis/actions/runs/3346622398/jobs/5564386148#step:5:604 . Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] SzyWilliam commented on pull request #771: RATIS-1733. Typo: fix misleading params names in `RaftServerConfigKeys`
Posted by GitBox <gi...@apache.org>.
SzyWilliam commented on PR #771:
URL: https://github.com/apache/ratis/pull/771#issuecomment-1298007623
@szetszwo Thanks for providing the patch! The good news is that this `NotSerializableException` disappears this time. The bad news is there's another error occurred. I'll take a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org