You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/16 18:29:31 UTC

[GitHub] [airflow] mik-laj opened a new pull request #8409: Use less fancy tables in CLI by default

mik-laj opened a new pull request #8409: Use less fancy tables in CLI by default
URL: https://github.com/apache/airflow/pull/8409
 
 
   Fancy grid is fancier but has the following disadvantages:
   * Takes up a lot more space, which makes reading difficult
      `AIRFLOW__CORE__DAGS_FOLDER=$(readlink -e airflow/providers/google/cloud/example_dags/) airflow dags list --output fancy_grid  | wc -l`=> 152
      `AIRFLOW__CORE__DAGS_FOLDER=$(readlink -e airflow/providers/google/cloud/example_dags/) airflow dags list --output plain  | wc -l`=> 76
    * Does not work with AWK and other Linux tools ( e.g. `airflow dags list  | awk '{print $2}'  | sort | uniq`). 
    * Is less popular  - `gcloud` uses plain table
   
   On the other hand, the only advantages of a fancy grid being fancier.
   
   Before:
   ![Screenshot 2020-04-16 at 20 26 02](https://user-images.githubusercontent.com/12058428/79492700-a2fcb280-8020-11ea-8fe0-e1c9b910b8c4.png)
   
   After:
   ![Screenshot 2020-04-16 at 20 24 41](https://user-images.githubusercontent.com/12058428/79492732-adb74780-8020-11ea-9a42-bf52e45e1e10.png)
   
   Because fancy_grid was not able to be parsed by Linux tools, this is not a breaking change. 
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb merged pull request #8409: Use less fancy tables in CLI by default

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #8409: Use less fancy tables in CLI by default
URL: https://github.com/apache/airflow/pull/8409
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services