You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 00:12:33 UTC

[GitHub] [arrow] rok edited a comment on pull request #12657: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

rok edited a comment on pull request #12657:
URL: https://github.com/apache/arrow/pull/12657#issuecomment-1083555420


   @djnavarro do you think this will cover requirements on R side?
   I've tried to use R to create the test data where possible and do sanity checks but I'm slowly developing test blindness :)
   
   @pitrou @jorisvandenbossche could you please review the changes here? The R style rounding demanded some more logic and maybe something I'm missing something that can be simplified.
   Also: perhaps we can find better variable names to replace `change_on_boundary` and `calendar_based_origin`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org