You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/18 15:26:41 UTC
[jira] [Commented] (BOOKKEEPER-1039) bk-merge-pr.py ask to run
findbugs and rat before merge
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972910#comment-15972910 ]
ASF GitHub Bot commented on BOOKKEEPER-1039:
--------------------------------------------
GitHub user eolivelli reopened a pull request:
https://github.com/apache/bookkeeper/pull/132
BOOKKEEPER-1039 bk-merge-pr.py ask to run findbugs and rat before merge
Add the ability to optionally run findbugs and apache RAT before every merge using the PR merge script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/bookkeeper BOOKKEEPER-1039-merge-findbugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit a2a7cd866e3dccffa7ec6607875d2333cd10d0a7
Author: eolivelli <eo...@apache.org>
Date: 2017-04-18T15:22:28Z
bk-merge-pr.py ask to run findbugs and rat before merge
----
> bk-merge-pr.py ask to run findbugs and rat before merge
> -------------------------------------------------------
>
> Key: BOOKKEEPER-1039
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1039
> Project: Bookkeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 4.5.0
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Critical
> Fix For: 4.5.0
>
>
> The bk-merge-pr.py script currently asks for running "mvn clean install".
> The full test suite is very slow.
> Many times we are merging patches which break findbugs and rat check
> I would like to add a step like
> "Do you want to validate findbugs and rat after the merge? (y/n)"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)