[jira] Commented: (HARMONY-3180) [drlvm][doc] Improved portlib docs

["Nadya Morozova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482442 ] 

Nadya Morozova commented on HARMONY-3180:
-----------------------------------------

Hello, Alexey.
I'm reviewing your patch for HARMONY-3180, and I'd like to thank you for your work. The mainpage now does not have the same text three times and is generally better. The other fixes are also fine , though can be further polished. I think we should commit to the repository and then add polishing fixes on top of it. Please let me know if you're ready to do more for these files. Or perhaps someone else could supply additional patches for your review. The remaining changes are about indentation inside comments, some missing punctuation, etc.

I'm ready to your fixes to all fixes except the atomics file, see below.
I've got a couple of questions. Sorry if question 2 causes some confusion (we renamed the port bundle into apr_extensions and been tossing files around, so there might be some inconsistency here that we're trying to fix). 

Port_atomic.h
Lines 97-100: 
Old (in your file): #elif defined ( WIN32 )
New (in current svn): #elif defined (WIN32) && !defined(_WIN64)
what do i write?

Mainpage
APR_Extensions bundle is all included in the intf target, but not all of these are linked from the front page. Is this ok? i've added a (!) sign to those that are in the table of the mainpage
apr_extension.intf= \
port/include/apr_thread_ext.h  \
port/include/clog.h  \
port/include/cxxlog.h  \
port/include/lil.h  \
port/include/lil_code_generator.h  \
port/include/lil_code_generator_utils.h  \
port/include/log_macro.h  \
port/include/logger.h  \
port/include/loggerstring.h  \
port/include/m2n.h  \
port/include/platform_core_natives.h  \
port/include/port_atomic.h  \ (!)
port/include/port_disasm.h  \ (!)
port/include/port_dso.h  \ (!)
port/include/port_filepath.h  \ (!)
port/include/port_general.h  \
port/include/port_malloc.h  \
port/include/port_sysinfo.h  \ (!)
port/include/port_timer.h  \ (!)
port/include/port_vmem.h  \
port/include/stack_iterator.h


> [drlvm][doc] Improved portlib docs
> ----------------------------------
>
>                 Key: HARMONY-3180
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3180
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM, Website/Documentation
>            Reporter: Alexey Varlamov
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: port_doc.diff
>
>
> Fixed & extended doxygen comments in portlib headers;
> Fixed mainpage (it had copy-pasted * 5 content);
> Fixed paths and config for doxygen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.