[GitHub] [samza] prateekm commented on a change in pull request #1029: Config logger

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1029: Config logger
URL: https://github.com/apache/samza/pull/1029#discussion_r284370490
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/config/ConfigLogger.java
 ##########
 @@ -0,0 +1,71 @@
+package org.apache.samza.config;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.function.Consumer;
+
+/**
+ * This logger logs the config line by line, while shortening the lines which are too long (over maxLen)
+ * Logging preserves the original logger name and may be redirected to a different file
+ * by specifying a logger name that starts with ConfigLogger. in log4j configuration.
+ */
+public class ConfigLogger {
 
 Review comment:
   What's the purpose of this class? Where is this used?
   
   I'd strongly prefer to not do this. IMHO it'll be much better to log these things (config, job model, starting offsets) as JSON instead, so that the log representation is compact but we can copy and "pretty print" in the IDE / browser for explorability.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services