[GitHub] [spark] maropu commented on a change in pull request #24004: [SPARK-27084][SQL] Add function alias for bitand/bitnot/bitor/bitxor

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #24004: [SPARK-27084][SQL] Add function alias for bitand/bitnot/bitor/bitxor
URL: https://github.com/apache/spark/pull/24004#discussion_r264072902
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ##########
 @@ -511,6 +511,11 @@ object FunctionRegistry {
     expression[BitwiseOr]("|"),
     expression[BitwiseXor]("^"),
 
+    expression[BitwiseAnd]("bitand"),
+    expression[BitwiseNot]("bitnot"),
+    expression[BitwiseOr]("bitor"),
+    expression[BitwiseXor]("bitxor"),
 
 Review comment:
   How about modifing the function a bit so that we could assign expression with multiple names?  
   ```
   expression[BitwiseAnd]("&", "bitand", ...),
   expression[BitwiseNot]("~", "bitnot", ...),
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org