[GitHub] [iceberg] rdblue commented on a diff in pull request #5594: Python: Fix CLI after properties refactor

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5594:
URL: https://github.com/apache/iceberg/pull/5594#discussion_r950750875


##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -133,23 +133,6 @@ def __init__(self, name: str, **properties: str):
         self.name = name
         self.properties = properties
 
-    def property(self, key: str) -> str:

Review Comment:
   I think it's best to remove this. There are places that bypass this check because the property is optional and `properties` are exposed to subclasses anyway. Since the subclasses need to pay attention to how `properties` are used, I think they should do that directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org