You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sotnich <gi...@git.apache.org> on 2017/01/11 15:53:20 UTC
[GitHub] zeppelin pull request #1886: [ZEPPELIN-1876] improved comptetion with schema...
GitHub user sotnich opened a pull request:
https://github.com/apache/zeppelin/pull/1886
[ZEPPELIN-1876] improved comptetion with schema/table/column separati\u2026
\u2026on + sqlcompleter tests
### What is this PR for?
This PR changes autocompletion behaviour in jdbc interpeter.
There are some changes:
* [main change] autocompletion now depends on what are you typing. Now there are four types of competion: schema, table, column and keywords. If you typing new word then autocompetion suggests only keywords and schema names. If you are typing after schema name with point then you get list of tables in that schema. Also if you typing a name after point after a table name you will get a list of column names of this table.
* autocomption now supports aliases in sql. If you write alias for a table in sql you will get a list of columns for an aliased table if you write down alias and point.
* autocompletion now load keywords only in low case (otherwise there are so many keywords in a list of autocompletion that it is becomes uncomfortable)
### What type of PR is it?
Improvement
### Todos
* [ ] - sort names in the output of autocompletion
* [ ] - list only schema names if we are typing a schema name (for example after keywork FROM)
* [ ] - add description in autocompletion list for schema names - schema, for table names - table and so
* [ ] - autocompletion must initialize on opening of interpeter (not only after execution of sql)
* [ ] - update autocompletion schemas only after execute update sql, not after every sql ???
* [ ] - new option for postgresql interpreter: postgresql.completer.schema.filter. Filter schema names loaded into autocompletion (no more garbage schema names).
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
https://issues.apache.org/jira/secure/attachment/12845228/auto1.JPG
https://issues.apache.org/jira/secure/attachment/12845229/auto2.JPG
https://issues.apache.org/jira/secure/attachment/12845230/auto3.JPG
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sotnich/zeppelin jdbc-1876
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1886
----
commit e9fde84884226f600455cdbd035d9a59b538300c
Author: Sotnichenko Sergey <s....@tinkoff.ru>
Date: 2017-01-11T11:40:46Z
[ZEPPELIN-1876] improved comptetion with schema/table/column separation + sqlcompleter tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@sotnich
now Well working!
good works!
Thank you for great feature!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by sotnich <gi...@git.apache.org>.
Github user sotnich commented on the issue:
https://github.com/apache/zeppelin/pull/1886
Made a rebase, now CI tests have only one error related with DistributedResourcePoolTest.
Think it's still not related to my PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1886: [ZEPPELIN-1876] improved comptetion with schema...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@sotnich Thank you for great improvement.
I tested `mysql` and `postgresql` and only `postgresql` is working expectedly like @cloverhearts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@sotnich
I was test.
LGTM.
I have a question.
Is it possible to only support pgsql? (actually, i am mysql/maria user)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1886
There is a flaky test in the result:
```
WelcomePageSuite
```
Never mind the result. that test is being fixed now. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by sotnich <gi...@git.apache.org>.
Github user sotnich commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@cloverhearts @astroshim
Made a little change - now mysql also works as well as postgresql. I have tested it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by sotnich <gi...@git.apache.org>.
Github user sotnich commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@cloverhearts
Please, clirify your question.
This PR supports every JDBC driver that can return schema and table names.
I have tested it on postgres, but I am sure it would correctly run on mysql and other relational databases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@astroshim Could you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by sotnich <gi...@git.apache.org>.
Github user sotnich commented on the issue:
https://github.com/apache/zeppelin/pull/1886
Don't think CI errors are related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1886
Hello, I was check again.
but, does not work on mysql.
Is there anything I missed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1886
CI failure is not related to this change.
LGTM and merge to master if no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@sotnich Great Job! but still doesn't work with `mysql`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by sotnich <gi...@git.apache.org>.
Github user sotnich commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@cloverhearts @astroshim, check it now, please. If it's still not working send me details: configuration of the interpreter and jdbc log file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1886
@sotnich Can you rebase it onto current master? Recently, we fixed some flaky tests including your case. It would make your CI green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1886
LGTM and merge to master if no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---