You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Viktor Somogyi-Vass <vi...@gmail.com> on 2018/10/24 12:28:00 UTC

[VOTE] KIP-377: TopicCommand to use AdminClient

Hi All,

I'd like to start a vote on KIP-377:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient.

Summary:
The KIP basically proposes to add --bootstrap-server and
--command-config option to TopicsCommand and implement topic
administration with AdminClient in a backwards compatible way (so
wouldn't drop or change the --zookeeper option usage).

I'd appreciate any votes or feedback.

Viktor

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Viktor Somogyi-Vass <vi...@gmail.com>.
Hi All,

I'm closing the vote as there has been a few days without any more
feedback and the KIP collected 3 binding votes (Gwen, Harsha and
Colin) and 2 non-binding (Mickael and Kevin) - therefore it got
accepted.
I'll update its status and work on the implementation (I have a WIP PR
but that still needs some changes to be done). As soon as it's ready
I'll ping this thread if anyone interested in the review.

Thank you all for participating the discussion and voting.

Viktor
On Thu, Oct 25, 2018 at 10:53 PM Gwen Shapira <gw...@confluent.io> wrote:
>
> +1 (binding)
> Thanks for working on this.
>
> On Wed, Oct 24, 2018, 7:28 AM Viktor Somogyi-Vass <vi...@gmail.com>
> wrote:
>
> > Hi All,
> >
> > I'd like to start a vote on KIP-377:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient
> > .
> >
> > Summary:
> > The KIP basically proposes to add --bootstrap-server and
> > --command-config option to TopicsCommand and implement topic
> > administration with AdminClient in a backwards compatible way (so
> > wouldn't drop or change the --zookeeper option usage).
> >
> > I'd appreciate any votes or feedback.
> >
> > Viktor
> >

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)
Thanks for working on this.

On Wed, Oct 24, 2018, 7:28 AM Viktor Somogyi-Vass <vi...@gmail.com>
wrote:

> Hi All,
>
> I'd like to start a vote on KIP-377:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient
> .
>
> Summary:
> The KIP basically proposes to add --bootstrap-server and
> --command-config option to TopicsCommand and implement topic
> administration with AdminClient in a backwards compatible way (so
> wouldn't drop or change the --zookeeper option usage).
>
> I'd appreciate any votes or feedback.
>
> Viktor
>

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Kevin Lu <lu...@berkeley.edu>.
+1 (non-binding)

Regards,
Kevin

On Thu, Oct 25, 2018 at 8:19 AM Harsha Chintalapani <ka...@harsha.io> wrote:

> Thanks for the KIP. +1 (binding).
> -Harsha
> On Oct 25, 2018, 10:40 AM -0400, Viktor Somogyi-Vass <
> viktorsomogyi@gmail.com>, wrote:
> > Thanks for the votes so far.
> >
> > @Colin: yup, I've added this to the KIP. Thanks.
> > On Thu, Oct 25, 2018 at 2:30 AM Colin McCabe <cm...@apache.org> wrote:
> > >
> > > Thanks, Viktor. +1 (binding).
> > >
> > > One note: can we add a deprecation warning when --zookeeper is used,
> to indicate that this option will be phased out in the future?
> > >
> > > best,
> > > Colin
> > >
> > > On Wed, Oct 24, 2018, at 05:47, Mickael Maison wrote:
> > > > +1 (non-binding)
> > > > Thanks for the KIP!
> > > > On Wed, Oct 24, 2018 at 1:28 PM Viktor Somogyi-Vass
> > > > <vi...@gmail.com> wrote:
> > > > >
> > > > > Hi All,
> > > > >
> > > > > I'd like to start a vote on KIP-377:
> > > > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient
> .
> > > > >
> > > > > Summary:
> > > > > The KIP basically proposes to add --bootstrap-server and
> > > > > --command-config option to TopicsCommand and implement topic
> > > > > administration with AdminClient in a backwards compatible way (so
> > > > > wouldn't drop or change the --zookeeper option usage).
> > > > >
> > > > > I'd appreciate any votes or feedback.
> > > > >
> > > > > Viktor
>

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Harsha Chintalapani <ka...@harsha.io>.
Thanks for the KIP. +1 (binding).
-Harsha
On Oct 25, 2018, 10:40 AM -0400, Viktor Somogyi-Vass <vi...@gmail.com>, wrote:
> Thanks for the votes so far.
>
> @Colin: yup, I've added this to the KIP. Thanks.
> On Thu, Oct 25, 2018 at 2:30 AM Colin McCabe <cm...@apache.org> wrote:
> >
> > Thanks, Viktor. +1 (binding).
> >
> > One note: can we add a deprecation warning when --zookeeper is used, to indicate that this option will be phased out in the future?
> >
> > best,
> > Colin
> >
> > On Wed, Oct 24, 2018, at 05:47, Mickael Maison wrote:
> > > +1 (non-binding)
> > > Thanks for the KIP!
> > > On Wed, Oct 24, 2018 at 1:28 PM Viktor Somogyi-Vass
> > > <vi...@gmail.com> wrote:
> > > >
> > > > Hi All,
> > > >
> > > > I'd like to start a vote on KIP-377:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient.
> > > >
> > > > Summary:
> > > > The KIP basically proposes to add --bootstrap-server and
> > > > --command-config option to TopicsCommand and implement topic
> > > > administration with AdminClient in a backwards compatible way (so
> > > > wouldn't drop or change the --zookeeper option usage).
> > > >
> > > > I'd appreciate any votes or feedback.
> > > >
> > > > Viktor

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Viktor Somogyi-Vass <vi...@gmail.com>.
Thanks for the votes so far.

@Colin: yup, I've added this to the KIP. Thanks.
On Thu, Oct 25, 2018 at 2:30 AM Colin McCabe <cm...@apache.org> wrote:
>
> Thanks, Viktor.  +1 (binding).
>
> One note: can we add a deprecation warning when --zookeeper is used, to indicate that this option will be phased out in the future?
>
> best,
> Colin
>
> On Wed, Oct 24, 2018, at 05:47, Mickael Maison wrote:
> > +1 (non-binding)
> > Thanks for the KIP!
> > On Wed, Oct 24, 2018 at 1:28 PM Viktor Somogyi-Vass
> > <vi...@gmail.com> wrote:
> > >
> > > Hi All,
> > >
> > > I'd like to start a vote on KIP-377:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient.
> > >
> > > Summary:
> > > The KIP basically proposes to add --bootstrap-server and
> > > --command-config option to TopicsCommand and implement topic
> > > administration with AdminClient in a backwards compatible way (so
> > > wouldn't drop or change the --zookeeper option usage).
> > >
> > > I'd appreciate any votes or feedback.
> > >
> > > Viktor

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Colin McCabe <cm...@apache.org>.
Thanks, Viktor.  +1 (binding).

One note: can we add a deprecation warning when --zookeeper is used, to indicate that this option will be phased out in the future?

best,
Colin

On Wed, Oct 24, 2018, at 05:47, Mickael Maison wrote:
> +1 (non-binding)
> Thanks for the KIP!
> On Wed, Oct 24, 2018 at 1:28 PM Viktor Somogyi-Vass
> <vi...@gmail.com> wrote:
> >
> > Hi All,
> >
> > I'd like to start a vote on KIP-377:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient.
> >
> > Summary:
> > The KIP basically proposes to add --bootstrap-server and
> > --command-config option to TopicsCommand and implement topic
> > administration with AdminClient in a backwards compatible way (so
> > wouldn't drop or change the --zookeeper option usage).
> >
> > I'd appreciate any votes or feedback.
> >
> > Viktor

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

Posted by Mickael Maison <mi...@gmail.com>.
+1 (non-binding)
Thanks for the KIP!
On Wed, Oct 24, 2018 at 1:28 PM Viktor Somogyi-Vass
<vi...@gmail.com> wrote:
>
> Hi All,
>
> I'd like to start a vote on KIP-377:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient.
>
> Summary:
> The KIP basically proposes to add --bootstrap-server and
> --command-config option to TopicsCommand and implement topic
> administration with AdminClient in a backwards compatible way (so
> wouldn't drop or change the --zookeeper option usage).
>
> I'd appreciate any votes or feedback.
>
> Viktor