You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/12/23 19:49:30 UTC
[GitHub] [phoenix] yanxinyi opened a new pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
yanxinyi opened a new pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664
…EW_TTL has expired
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365045034
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixMultiViewReader.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapreduce.InputSplit;
+import org.apache.hadoop.mapreduce.RecordReader;
+import org.apache.hadoop.mapreduce.TaskAttemptContext;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.ViewInfoWritable;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.List;
+
+public class PhoenixMultiViewReader<T extends Writable> extends
+ RecordReader<NullWritable,T> {
+ private Configuration configuration;
+ private Class<T> inputClass;
+ Iterator<ViewInfoWritable> it;
+
+ public PhoenixMultiViewReader(final Class<T> inputClass, final Configuration configuration) {
+ this.configuration = configuration;
+ this.inputClass = inputClass;
+ }
+
+ @Override public void initialize(InputSplit split, TaskAttemptContext context)
+ throws IOException, InterruptedException {
+ final PhoenixMultiViewInputSplit pSplit = (PhoenixMultiViewInputSplit)split;
+ final List<ViewInfoWritable> viewInfoTracker = pSplit.getViewInfoTrackerList();
+ it = viewInfoTracker.iterator();
+ }
+
+ @Override public boolean nextKeyValue() throws IOException, InterruptedException {
+ return it.hasNext();
+ }
+
+ @Override public NullWritable getCurrentKey() throws IOException, InterruptedException {
+ return null;
+ }
+
+ @Override public T getCurrentValue() throws IOException, InterruptedException {
+ ViewInfoWritable currentValue = null;
+ if (it.hasNext()) {
+ currentValue = it.next();
+ }
+ return (T)currentValue;
+ }
+
+ @Override public float getProgress() throws IOException, InterruptedException {
+ return 0;
Review comment:
Can we evaluate this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365049240
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTtlTool.java
##########
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.HelpFormatter;
+import org.apache.commons.cli.PosixParser;
+import org.apache.commons.cli.ParseException;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.Job;
+import org.apache.hadoop.mapreduce.JobPriority;
+import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixMapReduceUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.Connection;
+import java.util.Properties;
+
+
+public class ViewTtlTool extends Configured implements Tool {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTtlTool.class);
+
+ public static final String RUNNING_FOR_DELETE_ALL_VIEWS_STRING = "RUNNING_FOR_DELETE_ALL_VIEWS";
+
+ public static final int DEFAULT_MAPPER_SPLIT_SIZE = 10;
+
+ private static final Option DELETE_ALL_VIEW_OPTION = new Option("a", "all", false,
+ "Delete all views from all tables.");
+ private static final Option TABLE_NAME_OPTION = new Option("t", "table", true,
+ "Delete all children views from the Phoenix Table");
+ private static final Option VIEW_NAME_OPTION = new Option("v", "view", true,
+ "Delete Phoenix View Name");
+ private static final Option TENANT_ID_OPTION = new Option("i", "id", true,
+ "Delete an view based on the tenant id.");
+ private static final Option JOB_PRIORITY_OPTION = new Option("p", "job-priority", true,
+ "Define job priority from 0(highest) to 4");
+ private static final Option SPLIT_SIZE_OPTION = new Option("s", "split-size-per-mapper", true,
+ "Define split size for each mapper.");
+ private static final Option RUN_FOREGROUND_OPTION = new Option("runfg",
+ "run-foreground", false, "If specified, runs ViewTTLTool " +
+ "in Foreground. Default - Runs the build in background");
+
+ private static final Option HELP_OPTION = new Option("h", "help", false, "Help");
+
+ Configuration configuration;
+ Connection connection;
+
+ private String baseTableName;
+ private String viewName;
+ private String tenantId;
+ private String jobName;
+ private boolean isDeletingAllViews;
+ private JobPriority jobPriority;
+ private boolean isForeground;
+ private int splitSize;
+ private Job job;
+
+ public void parseArgs(String[] args) {
+ CommandLine cmdLine;
+ try {
+ cmdLine = parseOptions(args);
+ } catch (IllegalStateException e) {
+ printHelpAndExit(e.getMessage(), getOptions());
+ throw e;
+ }
+
+ if (getConf() == null) {
+ setConf(HBaseConfiguration.create());
+ }
+
+ if (cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt())) {
+ this.isDeletingAllViews = true;
+ } else if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())) {
+ baseTableName = cmdLine.getOptionValue(TABLE_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ } else if (cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ viewName = cmdLine.getOptionValue(VIEW_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ }
+
+ if (cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ tenantId = cmdLine.getOptionValue((TENANT_ID_OPTION.getOpt()));
+ }
+
+ jobPriority = getJobPriority(cmdLine);
+ if (cmdLine.hasOption(SPLIT_SIZE_OPTION.getOpt())) {
+ splitSize = Integer.valueOf(cmdLine.getOptionValue(SPLIT_SIZE_OPTION.getOpt()));
+ } else {
+ splitSize = DEFAULT_MAPPER_SPLIT_SIZE;
+ }
+ isForeground = cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt());
+ }
+
+ public String getJobPriority() {
+ return this.jobPriority.toString();
+ }
+
+ private JobPriority getJobPriority(CommandLine cmdLine) {
+ String jobPriorityOption = cmdLine.getOptionValue(JOB_PRIORITY_OPTION.getOpt());
+ if (jobPriorityOption == null) {
+ return JobPriority.NORMAL;
+ }
+
+ switch (jobPriorityOption) {
+ case "0" : return JobPriority.VERY_HIGH;
+ case "1" : return JobPriority.HIGH;
+ case "2" : return JobPriority.NORMAL;
+ case "3" : return JobPriority.LOW;
+ case "4" : return JobPriority.VERY_LOW;
+ default:
+ return JobPriority.NORMAL;
+ }
+ }
+
+ public boolean isDeletingAllViews() {
+ return this.isDeletingAllViews;
+ }
+
+ public String getTenantId() {
+ return this.tenantId;
+ }
+
+ public String getBaseTableName() {
+ return this.baseTableName;
+ }
+
+ public String getViewName() {
+ return this.viewName;
+ }
+
+ public int getSplitSize() {
+ return this.splitSize;
+ }
+
+ public CommandLine parseOptions(String[] args) {
+ final Options options = getOptions();
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmdLine = null;
+ try {
+ cmdLine = parser.parse(options, args);
+ } catch (ParseException e) {
+ printHelpAndExit("Error parsing command line options: " + e.getMessage(), options);
+ }
+
+ if (!cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt()) && !cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())
+ && !cmdLine.hasOption(VIEW_NAME_OPTION.getOpt()) && !cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ throw new IllegalStateException("No deletion job is specified, " +
+ "please indicate deletion job for ALL/TABLE/VIEW/TENANT level");
+ }
+
+ if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt()) && cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ throw new IllegalStateException("Table and View name options cannot be set at the same time");
+ }
+
+ if (cmdLine.hasOption(HELP_OPTION.getOpt())) {
+ printHelpAndExit(options, 0);
+ }
+
+ this.jobPriority = getJobPriority(cmdLine);
+
+ return cmdLine;
+ }
+
+ private Options getOptions() {
+ final Options options = new Options();
+ options.addOption(DELETE_ALL_VIEW_OPTION);
+ options.addOption(TABLE_NAME_OPTION);
+ options.addOption(VIEW_NAME_OPTION);
+ options.addOption(TENANT_ID_OPTION);
+ options.addOption(HELP_OPTION);
+ options.addOption(JOB_PRIORITY_OPTION);
+ options.addOption(RUN_FOREGROUND_OPTION);
+ options.addOption(SPLIT_SIZE_OPTION);
+
+ return options;
+ }
+
+ private void printHelpAndExit(String errorMessage, Options options) {
+ System.err.println(errorMessage);
+ printHelpAndExit(options, 1);
+ }
+
+ private void printHelpAndExit(Options options, int exitCode) {
+ HelpFormatter formatter = new HelpFormatter();
+ formatter.printHelp("help", options);
+ System.exit(exitCode);
+ }
+
+ public void setJobName(String jobName) {
+ this.jobName = jobName;
+ }
+
+ public String getJobName() {
+ if (this.jobName == null) {
+ String jobName;
+ if (this.isDeletingAllViews) {
+ jobName = RUNNING_FOR_DELETE_ALL_VIEWS_STRING;
+ } else if (this.getBaseTableName() != null) {
+ jobName = this.getBaseTableName();
+ } else if (this.getViewName() != null) {
+ jobName = this.getViewName();
+ } else {
+ jobName = this.tenantId;
+ }
+ this.jobName = "ViewTTLTool-" + jobName + "-";
+ }
+
+ return this.jobName;
+ }
+
+ public void setViewTTLJobInputConfig(Configuration configuration) {
+ if (this.isDeletingAllViews) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_ALL_VIEWS,
+ RUNNING_FOR_DELETE_ALL_VIEWS_STRING);
+ } else if (this.getBaseTableName() != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_PER_TABLE,
+ this.baseTableName);
+ } else if (this.getViewName() != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_PER_VIEW,
+ this.viewName);
+ }
+
+ if (this.tenantId != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_TENANT_ID, this.tenantId);
+ }
+ }
+
+ public void configureJob() throws Exception {
+ this.job = Job.getInstance(getConf(),getJobName() + System.currentTimeMillis());
+ PhoenixMapReduceUtil.setInput(job, this);
+
+ job.setJarByClass(ViewTtlTool.class);
+ job.setMapperClass(ViewTTLDeleteJobMapper.class);
+ job.setMapOutputKeyClass(NullWritable.class);
+ job.setMapOutputValueClass(NullWritable.class);
+ job.setOutputFormatClass(NullOutputFormat.class);
+ job.setNumReduceTasks(0);
+ job.setPriority(this.jobPriority);
+
+ TableMapReduceUtil.addDependencyJars(job);
+ LOGGER.info("ViewTTLTool is running for " + job.getJobName());
+ }
+
+ public int runJob() {
+ try {
+ if (isForeground) {
+ LOGGER.info("Running ViewTTLTool in Foreground. " +
Review comment:
nit: lower case "foreground"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365046002
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
+ }
+ }
+
+ private void deletingExpiredRows(PhoenixConnection connection, ViewInfoTracker value, Configuration config)
+ throws SQLException {
+ PTable view = PhoenixRuntime.getTable(connection, value.getViewName());
+
+ String deleteIfExpiredStatement = "SELECT /*+ NO_INDEX */ count(*) FROM " + value.getViewName();
+ deletingExpiredRows(connection, view, Long.valueOf(value.getViewTtl()),
+ deleteIfExpiredStatement, config);
+ List<PTable> allIndexesOnView = view.getIndexes();
Review comment:
@yanxinyi We are only deleting from view indexes right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365050462
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMultiViewDeletionInputStrategy.java
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce.util;
+
+import org.apache.hadoop.conf.Configuration;
+import java.util.List;
+
+public interface PhoenixMultiViewDeletionInputStrategy {
+ List<ViewInfoWritable> getViewsWithTTL(Configuration configuration);
Review comment:
And call this method getViewInfoList(...)/getPhoenixMultiViewList(...), that way it will be more generic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r364883392
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
Review comment:
do you think putting this below map function makes it more readable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r364885682
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
+ }
+ }
+
+ private void deletingExpiredRows(PhoenixConnection connection, ViewInfoTracker value, Configuration config)
+ throws SQLException {
+ PTable view = PhoenixRuntime.getTable(connection, value.getViewName());
+
+ String deleteIfExpiredStatement = "SELECT /*+ NO_INDEX */ count(*) FROM " + value.getViewName();
+ deletingExpiredRows(connection, view, Long.valueOf(value.getViewTtl()),
+ deleteIfExpiredStatement, config);
+ List<PTable> allIndexesOnView = view.getIndexes();
Review comment:
AFAIK, this also gets indexes on the base table. Is it expected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365049700
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMultiViewDeletionInputStrategy.java
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce.util;
+
+import org.apache.hadoop.conf.Configuration;
+import java.util.List;
+
+public interface PhoenixMultiViewDeletionInputStrategy {
Review comment:
nit: Can we call this class PhoenixMultiViewListProvider?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365048586
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTtlTool.java
##########
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.HelpFormatter;
+import org.apache.commons.cli.PosixParser;
+import org.apache.commons.cli.ParseException;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.Job;
+import org.apache.hadoop.mapreduce.JobPriority;
+import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixMapReduceUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.Connection;
+import java.util.Properties;
+
+
+public class ViewTtlTool extends Configured implements Tool {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTtlTool.class);
+
+ public static final String RUNNING_FOR_DELETE_ALL_VIEWS_STRING = "RUNNING_FOR_DELETE_ALL_VIEWS";
+
+ public static final int DEFAULT_MAPPER_SPLIT_SIZE = 10;
+
+ private static final Option DELETE_ALL_VIEW_OPTION = new Option("a", "all", false,
+ "Delete all views from all tables.");
+ private static final Option TABLE_NAME_OPTION = new Option("t", "table", true,
+ "Delete all children views from the Phoenix Table");
+ private static final Option VIEW_NAME_OPTION = new Option("v", "view", true,
+ "Delete Phoenix View Name");
+ private static final Option TENANT_ID_OPTION = new Option("i", "id", true,
+ "Delete an view based on the tenant id.");
+ private static final Option JOB_PRIORITY_OPTION = new Option("p", "job-priority", true,
+ "Define job priority from 0(highest) to 4");
+ private static final Option SPLIT_SIZE_OPTION = new Option("s", "split-size-per-mapper", true,
+ "Define split size for each mapper.");
+ private static final Option RUN_FOREGROUND_OPTION = new Option("runfg",
+ "run-foreground", false, "If specified, runs ViewTTLTool " +
+ "in Foreground. Default - Runs the build in background");
+
+ private static final Option HELP_OPTION = new Option("h", "help", false, "Help");
+
+ Configuration configuration;
+ Connection connection;
+
+ private String baseTableName;
+ private String viewName;
+ private String tenantId;
+ private String jobName;
+ private boolean isDeletingAllViews;
+ private JobPriority jobPriority;
+ private boolean isForeground;
+ private int splitSize;
+ private Job job;
+
+ public void parseArgs(String[] args) {
+ CommandLine cmdLine;
+ try {
+ cmdLine = parseOptions(args);
+ } catch (IllegalStateException e) {
+ printHelpAndExit(e.getMessage(), getOptions());
+ throw e;
+ }
+
+ if (getConf() == null) {
+ setConf(HBaseConfiguration.create());
+ }
+
+ if (cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt())) {
+ this.isDeletingAllViews = true;
+ } else if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())) {
+ baseTableName = cmdLine.getOptionValue(TABLE_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ } else if (cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ viewName = cmdLine.getOptionValue(VIEW_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ }
+
+ if (cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ tenantId = cmdLine.getOptionValue((TENANT_ID_OPTION.getOpt()));
+ }
+
+ jobPriority = getJobPriority(cmdLine);
+ if (cmdLine.hasOption(SPLIT_SIZE_OPTION.getOpt())) {
+ splitSize = Integer.valueOf(cmdLine.getOptionValue(SPLIT_SIZE_OPTION.getOpt()));
+ } else {
+ splitSize = DEFAULT_MAPPER_SPLIT_SIZE;
+ }
+ isForeground = cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt());
+ }
+
+ public String getJobPriority() {
+ return this.jobPriority.toString();
+ }
+
+ private JobPriority getJobPriority(CommandLine cmdLine) {
+ String jobPriorityOption = cmdLine.getOptionValue(JOB_PRIORITY_OPTION.getOpt());
+ if (jobPriorityOption == null) {
+ return JobPriority.NORMAL;
+ }
+
+ switch (jobPriorityOption) {
+ case "0" : return JobPriority.VERY_HIGH;
+ case "1" : return JobPriority.HIGH;
+ case "2" : return JobPriority.NORMAL;
+ case "3" : return JobPriority.LOW;
+ case "4" : return JobPriority.VERY_LOW;
+ default:
+ return JobPriority.NORMAL;
+ }
+ }
+
+ public boolean isDeletingAllViews() {
+ return this.isDeletingAllViews;
+ }
+
+ public String getTenantId() {
+ return this.tenantId;
+ }
+
+ public String getBaseTableName() {
+ return this.baseTableName;
+ }
+
+ public String getViewName() {
+ return this.viewName;
+ }
+
+ public int getSplitSize() {
+ return this.splitSize;
+ }
+
+ public CommandLine parseOptions(String[] args) {
+ final Options options = getOptions();
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmdLine = null;
+ try {
+ cmdLine = parser.parse(options, args);
+ } catch (ParseException e) {
+ printHelpAndExit("Error parsing command line options: " + e.getMessage(), options);
+ }
+
+ if (!cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt()) && !cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())
+ && !cmdLine.hasOption(VIEW_NAME_OPTION.getOpt()) && !cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ throw new IllegalStateException("No deletion job is specified, " +
+ "please indicate deletion job for ALL/TABLE/VIEW/TENANT level");
+ }
+
+ if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt()) && cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ throw new IllegalStateException("Table and View name options cannot be set at the same time");
+ }
+
+ if (cmdLine.hasOption(HELP_OPTION.getOpt())) {
+ printHelpAndExit(options, 0);
+ }
+
+ this.jobPriority = getJobPriority(cmdLine);
+
+ return cmdLine;
+ }
+
+ private Options getOptions() {
+ final Options options = new Options();
+ options.addOption(DELETE_ALL_VIEW_OPTION);
+ options.addOption(TABLE_NAME_OPTION);
+ options.addOption(VIEW_NAME_OPTION);
+ options.addOption(TENANT_ID_OPTION);
+ options.addOption(HELP_OPTION);
+ options.addOption(JOB_PRIORITY_OPTION);
+ options.addOption(RUN_FOREGROUND_OPTION);
+ options.addOption(SPLIT_SIZE_OPTION);
+
+ return options;
+ }
+
+ private void printHelpAndExit(String errorMessage, Options options) {
+ System.err.println(errorMessage);
+ printHelpAndExit(options, 1);
+ }
+
+ private void printHelpAndExit(Options options, int exitCode) {
+ HelpFormatter formatter = new HelpFormatter();
+ formatter.printHelp("help", options);
+ System.exit(exitCode);
+ }
+
+ public void setJobName(String jobName) {
+ this.jobName = jobName;
+ }
+
+ public String getJobName() {
+ if (this.jobName == null) {
Review comment:
nit: Can we define a job name format and build that consistently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r374291995
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTtlTool.java
##########
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.HelpFormatter;
+import org.apache.commons.cli.PosixParser;
+import org.apache.commons.cli.ParseException;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.Job;
+import org.apache.hadoop.mapreduce.JobPriority;
+import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixMapReduceUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.Connection;
+import java.util.Properties;
+
+
+public class ViewTtlTool extends Configured implements Tool {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTtlTool.class);
+
+ public static final String RUNNING_FOR_DELETE_ALL_VIEWS_STRING = "RUNNING_FOR_DELETE_ALL_VIEWS";
+
+ public static final int DEFAULT_MAPPER_SPLIT_SIZE = 10;
+
+ private static final Option DELETE_ALL_VIEW_OPTION = new Option("a", "all", false,
+ "Delete all views from all tables.");
+ private static final Option TABLE_NAME_OPTION = new Option("t", "table", true,
+ "Delete all children views from the Phoenix Table");
+ private static final Option VIEW_NAME_OPTION = new Option("v", "view", true,
+ "Delete Phoenix View Name");
+ private static final Option TENANT_ID_OPTION = new Option("i", "id", true,
+ "Delete an view based on the tenant id.");
+ private static final Option JOB_PRIORITY_OPTION = new Option("p", "job-priority", true,
+ "Define job priority from 0(highest) to 4");
+ private static final Option SPLIT_SIZE_OPTION = new Option("s", "split-size-per-mapper", true,
+ "Define split size for each mapper.");
+ private static final Option RUN_FOREGROUND_OPTION = new Option("runfg",
+ "run-foreground", false, "If specified, runs ViewTTLTool " +
+ "in Foreground. Default - Runs the build in background");
+
+ private static final Option HELP_OPTION = new Option("h", "help", false, "Help");
+
+ Configuration configuration;
+ Connection connection;
+
+ private String baseTableName;
+ private String viewName;
+ private String tenantId;
+ private String jobName;
+ private boolean isDeletingAllViews;
+ private JobPriority jobPriority;
+ private boolean isForeground;
+ private int splitSize;
+ private Job job;
+
+ public void parseArgs(String[] args) {
+ CommandLine cmdLine;
+ try {
+ cmdLine = parseOptions(args);
+ } catch (IllegalStateException e) {
+ printHelpAndExit(e.getMessage(), getOptions());
+ throw e;
+ }
+
+ if (getConf() == null) {
+ setConf(HBaseConfiguration.create());
+ }
+
+ if (cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt())) {
+ this.isDeletingAllViews = true;
+ } else if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())) {
+ baseTableName = cmdLine.getOptionValue(TABLE_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ } else if (cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ viewName = cmdLine.getOptionValue(VIEW_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ }
+
+ if (cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ tenantId = cmdLine.getOptionValue((TENANT_ID_OPTION.getOpt()));
+ }
+
+ jobPriority = getJobPriority(cmdLine);
+ if (cmdLine.hasOption(SPLIT_SIZE_OPTION.getOpt())) {
+ splitSize = Integer.valueOf(cmdLine.getOptionValue(SPLIT_SIZE_OPTION.getOpt()));
+ } else {
+ splitSize = DEFAULT_MAPPER_SPLIT_SIZE;
+ }
+ isForeground = cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt());
+ }
+
+ public String getJobPriority() {
+ return this.jobPriority.toString();
+ }
+
+ private JobPriority getJobPriority(CommandLine cmdLine) {
+ String jobPriorityOption = cmdLine.getOptionValue(JOB_PRIORITY_OPTION.getOpt());
+ if (jobPriorityOption == null) {
+ return JobPriority.NORMAL;
+ }
+
+ switch (jobPriorityOption) {
+ case "0" : return JobPriority.VERY_HIGH;
+ case "1" : return JobPriority.HIGH;
+ case "2" : return JobPriority.NORMAL;
+ case "3" : return JobPriority.LOW;
+ case "4" : return JobPriority.VERY_LOW;
+ default:
+ return JobPriority.NORMAL;
+ }
+ }
+
+ public boolean isDeletingAllViews() {
+ return this.isDeletingAllViews;
+ }
+
+ public String getTenantId() {
+ return this.tenantId;
+ }
+
+ public String getBaseTableName() {
+ return this.baseTableName;
+ }
+
+ public String getViewName() {
+ return this.viewName;
+ }
+
+ public int getSplitSize() {
+ return this.splitSize;
+ }
+
+ public CommandLine parseOptions(String[] args) {
+ final Options options = getOptions();
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmdLine = null;
+ try {
+ cmdLine = parser.parse(options, args);
+ } catch (ParseException e) {
+ printHelpAndExit("Error parsing command line options: " + e.getMessage(), options);
+ }
+
+ if (!cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt()) && !cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())
+ && !cmdLine.hasOption(VIEW_NAME_OPTION.getOpt()) && !cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ throw new IllegalStateException("No deletion job is specified, " +
+ "please indicate deletion job for ALL/TABLE/VIEW/TENANT level");
+ }
+
+ if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt()) && cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ throw new IllegalStateException("Table and View name options cannot be set at the same time");
+ }
+
+ if (cmdLine.hasOption(HELP_OPTION.getOpt())) {
+ printHelpAndExit(options, 0);
+ }
+
+ this.jobPriority = getJobPriority(cmdLine);
+
+ return cmdLine;
+ }
+
+ private Options getOptions() {
+ final Options options = new Options();
+ options.addOption(DELETE_ALL_VIEW_OPTION);
+ options.addOption(TABLE_NAME_OPTION);
+ options.addOption(VIEW_NAME_OPTION);
+ options.addOption(TENANT_ID_OPTION);
+ options.addOption(HELP_OPTION);
+ options.addOption(JOB_PRIORITY_OPTION);
+ options.addOption(RUN_FOREGROUND_OPTION);
+ options.addOption(SPLIT_SIZE_OPTION);
+
+ return options;
+ }
+
+ private void printHelpAndExit(String errorMessage, Options options) {
+ System.err.println(errorMessage);
+ printHelpAndExit(options, 1);
+ }
+
+ private void printHelpAndExit(Options options, int exitCode) {
+ HelpFormatter formatter = new HelpFormatter();
+ formatter.printHelp("help", options);
+ System.exit(exitCode);
+ }
+
+ public void setJobName(String jobName) {
+ this.jobName = jobName;
+ }
+
+ public String getJobName() {
+ if (this.jobName == null) {
Review comment:
all jobs start with prefix `ViewTTLTool-`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r364998377
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
+ }
+ }
+
+ private void deletingExpiredRows(PhoenixConnection connection, ViewInfoTracker value, Configuration config)
+ throws SQLException {
+ PTable view = PhoenixRuntime.getTable(connection, value.getViewName());
+
+ String deleteIfExpiredStatement = "SELECT /*+ NO_INDEX */ count(*) FROM " + value.getViewName();
+ deletingExpiredRows(connection, view, Long.valueOf(value.getViewTtl()),
+ deleteIfExpiredStatement, config);
+ List<PTable> allIndexesOnView = view.getIndexes();
Review comment:
that's expected. We delete expired rows for the base table, as well as the index table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365046995
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
Review comment:
I am assuming these are for global views? And have been validated that they do not have any child views. It would be useful to pass that info (global/tenant view) in the value (ViewInfoTracker) so that additional validation can be done here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365047157
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
Review comment:
+1 to addtional custom message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on issue #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on issue #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#issuecomment-614415457
close this PR since implementation changes. the new PR is here: https://github.com/apache/phoenix/pull/762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365047157
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
Review comment:
+1 to additional custom message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r374291087
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
+ }
+ }
+
+ private void deletingExpiredRows(PhoenixConnection connection, ViewInfoTracker value, Configuration config)
+ throws SQLException {
+ PTable view = PhoenixRuntime.getTable(connection, value.getViewName());
+
+ String deleteIfExpiredStatement = "SELECT /*+ NO_INDEX */ count(*) FROM " + value.getViewName();
+ deletingExpiredRows(connection, view, Long.valueOf(value.getViewTtl()),
+ deleteIfExpiredStatement, config);
+ List<PTable> allIndexesOnView = view.getIndexes();
Review comment:
yes. that's correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r364883984
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
+ }
+
+ } catch (SQLException e) {
+ LOGGER.error(e.getErrorCode() + e.getSQLState(), e.getStackTrace());
Review comment:
nit: good to put a custom message string so that it can come handy in debugging sessions if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r374290555
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.JobStatus;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.ConnectionUtil;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.mapreduce.util.ViewInfoTracker;
+import org.apache.phoenix.mapreduce.util.MultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.DefaultMultiViewJobStatusTracker;
+import org.apache.phoenix.mapreduce.util.PhoenixViewTtlUtil;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+public class ViewTTLDeleteJobMapper extends Mapper<NullWritable, ViewInfoTracker, NullWritable, NullWritable> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLDeleteJobMapper.class);
+ private MultiViewJobStatusTracker multiViewJobStatusTracker;
+
+ private void initMultiViewJobStatusTracker(Configuration config) {
+ try {
+ Class<?> defaultViewDeletionTrackerClass = DefaultMultiViewJobStatusTracker.class;
+ if (config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ) != null) {
+ LOGGER.info("Using customized tracker class : " + config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ defaultViewDeletionTrackerClass = Class.forName(
+ config.get(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_MAPPER_TRACKER_CLAZZ));
+ } else {
+ LOGGER.info("Using default tracker class ");
+ }
+ this.multiViewJobStatusTracker = (MultiViewJobStatusTracker) defaultViewDeletionTrackerClass.newInstance();
+ } catch (Exception e) {
+ LOGGER.info("exception " + e.getMessage());
+ LOGGER.info("stack trace" + e.getStackTrace().toString());
+ }
+ }
+
+ @Override
+ protected void map(NullWritable key, ViewInfoTracker value,
+ Context context) {
+ final Configuration config = context.getConfiguration();
+
+ if (this.multiViewJobStatusTracker == null) {
+ initMultiViewJobStatusTracker(config);
+ }
+
+ LOGGER.debug(String.format("Deleting from view %s, TenantID %s, and TTL value: %d",
+ value.getViewName(), value.getTenantId(), value.getViewTtl()));
+
+ try (PhoenixConnection connection =(PhoenixConnection) ConnectionUtil.getInputConnection(config) ){
+ if (value.getTenantId() != null && !value.getTenantId().equals("NULL")) {
+ try (PhoenixConnection tenantConnection = (PhoenixConnection)PhoenixViewTtlUtil.
+ buildTenantConnection(connection.getURL(), value.getTenantId())) {
+ deletingExpiredRows(tenantConnection, value, config);
+ }
+ } else {
+ deletingExpiredRows(connection, value, config);
Review comment:
We already did check before passing to the mapper. In other words, only leaf view can be processed and deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r365047610
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTtlTool.java
##########
@@ -0,0 +1,314 @@
+/*
Review comment:
nit: Should the file/class name be ViewTTLTool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r361241938
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTtlTool.java
##########
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.HelpFormatter;
+import org.apache.commons.cli.PosixParser;
+import org.apache.commons.cli.ParseException;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.Job;
+import org.apache.hadoop.mapreduce.JobPriority;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.*;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.List;
+import java.util.Properties;
+
+
+public class ViewTtlTool extends Configured implements Tool {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTtlTool.class);
+
+ public static final String RUNNING_FOR_DELETE_ALL_VIEWS_STRING = "RUNNING_FOR_DELETE_ALL_VIEWS";
+
+ public static final int DEFAULT_MAPPER_SPLIT_SIZE = 10;
+
+ private static final Option DELETE_ALL_VIEW_OPTION = new Option("a", "all", false,
+ "Delete all views from all tables.");
+ private static final Option TABLE_NAME_OPTION = new Option("t", "table", true,
+ "Delete all children views from the Phoenix Table");
+ private static final Option VIEW_NAME_OPTION = new Option("v", "view", true,
+ "Delete Phoenix View Name");
+ private static final Option TENANT_ID_OPTION = new Option("i", "id", true,
+ "Delete an view based on the tenant id.");
+ private static final Option JOB_PRIORITY_OPTION = new Option("p", "job-priority", true,
+ "Define job priority from 0(highest) to 4");
+ private static final Option SPLIT_SIZE_OPTION = new Option("s", "split-size-per-mapper", true,
+ "Define split size for each mapper.");
+ private static final Option RUN_FOREGROUND_OPTION = new Option("runfg",
+ "run-foreground", false, "If specified, runs ViewTTLTool " +
+ "in Foreground. Default - Runs the build in background");
+
+ private static final Option HELP_OPTION = new Option("h", "help", false, "Help");
+
+ Configuration configuration;
+ Connection connection;
+
+ private String baseTableName;
+ private String viewName;
+ private String tenantId;
+ private String jobName;
+ private boolean isDeletingAllViews;
+ private JobPriority jobPriority;
+ private boolean isForeground;
+ private int splitSize;
+ private Job job;
+
+ public void parseArgs(String[] args) {
+ CommandLine cmdLine;
+ try {
+ cmdLine = parseOptions(args);
+ } catch (IllegalStateException e) {
+ printHelpAndExit(e.getMessage(), getOptions());
+ throw e;
+ }
+
+ if (getConf() == null) {
+ setConf(HBaseConfiguration.create());
+ }
+
+ if (cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt())) {
+ this.isDeletingAllViews = true;
+ } else if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())) {
+ baseTableName = cmdLine.getOptionValue(TABLE_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ } else if (cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ viewName = cmdLine.getOptionValue(VIEW_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ }
+
+ if (cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ tenantId = cmdLine.getOptionValue((TENANT_ID_OPTION.getOpt()));
+ }
+
+ jobPriority = getJobPriority(cmdLine);
+ if (cmdLine.hasOption(SPLIT_SIZE_OPTION.getOpt())) {
+ splitSize = Integer.valueOf(cmdLine.getOptionValue(SPLIT_SIZE_OPTION.getOpt()));
+ } else {
+ splitSize = DEFAULT_MAPPER_SPLIT_SIZE;
+ }
+ isForeground = cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt());
+ }
+
+ public String getJobPriority() {
+ return this.jobPriority.toString();
+ }
+
+ private JobPriority getJobPriority(CommandLine cmdLine) {
+ String jobPriorityOption = cmdLine.getOptionValue(JOB_PRIORITY_OPTION.getOpt());
+ if (jobPriorityOption == null) {
+ return JobPriority.NORMAL;
+ }
+
+ switch (jobPriorityOption) {
+ case "0" : return JobPriority.VERY_HIGH;
+ case "1" : return JobPriority.HIGH;
+ case "2" : return JobPriority.NORMAL;
+ case "3" : return JobPriority.LOW;
+ case "4" : return JobPriority.VERY_LOW;
+ default:
+ return JobPriority.NORMAL;
+ }
+ }
+
+ public boolean isDeletingAllViews() {
+ return this.isDeletingAllViews;
+ }
+
+ public String getTenantId() {
+ return this.tenantId;
+ }
+
+ public String getBaseTableName() {
+ return this.baseTableName;
+ }
+
+ public String getViewName() {
+ return this.viewName;
+ }
+
+ public int getSplitSize() {
+ return this.splitSize;
+ }
+
+ public CommandLine parseOptions(String[] args) {
+ final Options options = getOptions();
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmdLine = null;
+ try {
+ cmdLine = parser.parse(options, args);
+ } catch (ParseException e) {
+ printHelpAndExit("Error parsing command line options: " + e.getMessage(), options);
+ }
+
+ if (!cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt()) && !cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())
+ && !cmdLine.hasOption(VIEW_NAME_OPTION.getOpt()) && !cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ throw new IllegalStateException("No deletion job is specified, " +
+ "please indicate deletion job for ALL/TABLE/VIEW/TENANT level");
+ }
+
+ if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt()) && cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ throw new IllegalStateException("Table and View name options cannot be set at the same time");
+ }
+
+ if (cmdLine.hasOption(HELP_OPTION.getOpt())) {
+ printHelpAndExit(options, 0);
+ }
+
+ this.jobPriority = getJobPriority(cmdLine);
+
+ return cmdLine;
+ }
+
+ private Options getOptions() {
+ final Options options = new Options();
+ options.addOption(DELETE_ALL_VIEW_OPTION);
+ options.addOption(TABLE_NAME_OPTION);
+ options.addOption(VIEW_NAME_OPTION);
+ options.addOption(TENANT_ID_OPTION);
+ options.addOption(HELP_OPTION);
+ options.addOption(JOB_PRIORITY_OPTION);
+ options.addOption(RUN_FOREGROUND_OPTION);
+ options.addOption(SPLIT_SIZE_OPTION);
+
+ return options;
+ }
+
+ private void printHelpAndExit(String errorMessage, Options options) {
+ System.err.println(errorMessage);
+ printHelpAndExit(options, 1);
+ }
+
+ private void printHelpAndExit(Options options, int exitCode) {
+ HelpFormatter formatter = new HelpFormatter();
+ formatter.printHelp("help", options);
+ System.exit(exitCode);
+ }
+
+ public void setJobName(String jobName) {
+ this.jobName = jobName;
+ }
+
+ public String getJobName() {
+ if (this.jobName == null) {
+ String jobName;
+ if (this.isDeletingAllViews) {
+ jobName = RUNNING_FOR_DELETE_ALL_VIEWS_STRING;
+ } else if (this.getBaseTableName() != null) {
+ jobName = this.getBaseTableName();
+ } else if (this.getViewName() != null) {
+ jobName = this.getViewName();
+ } else {
+ jobName = this.tenantId;
+ }
+ this.jobName = "ViewTTLTool-" + jobName + "-";
+ }
+
+ return this.jobName;
+ }
+
+ public void setViewTTLJobInputConfig(Configuration configuration) {
+ if (this.isDeletingAllViews) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_ALL_VIEWS,
+ RUNNING_FOR_DELETE_ALL_VIEWS_STRING);
+ } else if (this.getBaseTableName() != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_PER_TABLE,
+ this.baseTableName);
+ } else if (this.getViewName() != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_PER_VIEW,
+ this.viewName);
+ }
+
+ if (this.tenantId != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_TENANT_ID, this.tenantId);
+ }
+ }
+
+ public void configureJob() throws Exception {
+ this.job = Job.getInstance(getConf(),getJobName() + System.currentTimeMillis());
+ PhoenixMapReduceUtil.setInput(job, this);
+
+ job.setJarByClass(ViewTtlTool.class);
+ job.setMapperClass(ViewTTLDeleteJobMapper.class);
+ job.setMapOutputKeyClass(NullWritable.class);
+ job.setMapOutputValueClass(NullWritable.class);
+ job.setOutputFormatClass(NullOutputFormat.class);
+ job.setNumReduceTasks(0);
+ job.setPriority(this.jobPriority);
+
+ TableMapReduceUtil.addDependencyJars(job);
+ LOGGER.info("ViewTTLTool is running for " + job.getJobName());
+ }
+
+ public int runJob() {
+ try {
+ if (isForeground) {
+ LOGGER.info("Running ViewTTLTool in Foreground. " +
+ "Runs full table scans. This may take a long time!");
+ return (job.waitForCompletion(true)) ? 0 : 1;
+ } else {
+ LOGGER.info("Running ViewTTLTool in Background - Submit async and exit");
+ job.submit();
+ return 0;
+ }
+ } catch (Exception e) {
+ LOGGER.error("Caught exception " + e + " trying to run ViewTTLTool.");
+ return 1;
+ }
+ }
+
+ public static class ViewTTLDeleteJobMapper
Review comment:
why not create a different file for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #664: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
URL: https://github.com/apache/phoenix/pull/664#discussion_r361241938
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTtlTool.java
##########
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.mapreduce;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.HelpFormatter;
+import org.apache.commons.cli.PosixParser;
+import org.apache.commons.cli.ParseException;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapreduce.Job;
+import org.apache.hadoop.mapreduce.JobPriority;
+import org.apache.hadoop.mapreduce.Mapper;
+import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.coprocessor.BaseScannerRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixResultSet;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.util.*;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.schema.PTable;
+import org.apache.phoenix.schema.types.PDataType;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.SchemaUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.List;
+import java.util.Properties;
+
+
+public class ViewTtlTool extends Configured implements Tool {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ViewTtlTool.class);
+
+ public static final String RUNNING_FOR_DELETE_ALL_VIEWS_STRING = "RUNNING_FOR_DELETE_ALL_VIEWS";
+
+ public static final int DEFAULT_MAPPER_SPLIT_SIZE = 10;
+
+ private static final Option DELETE_ALL_VIEW_OPTION = new Option("a", "all", false,
+ "Delete all views from all tables.");
+ private static final Option TABLE_NAME_OPTION = new Option("t", "table", true,
+ "Delete all children views from the Phoenix Table");
+ private static final Option VIEW_NAME_OPTION = new Option("v", "view", true,
+ "Delete Phoenix View Name");
+ private static final Option TENANT_ID_OPTION = new Option("i", "id", true,
+ "Delete an view based on the tenant id.");
+ private static final Option JOB_PRIORITY_OPTION = new Option("p", "job-priority", true,
+ "Define job priority from 0(highest) to 4");
+ private static final Option SPLIT_SIZE_OPTION = new Option("s", "split-size-per-mapper", true,
+ "Define split size for each mapper.");
+ private static final Option RUN_FOREGROUND_OPTION = new Option("runfg",
+ "run-foreground", false, "If specified, runs ViewTTLTool " +
+ "in Foreground. Default - Runs the build in background");
+
+ private static final Option HELP_OPTION = new Option("h", "help", false, "Help");
+
+ Configuration configuration;
+ Connection connection;
+
+ private String baseTableName;
+ private String viewName;
+ private String tenantId;
+ private String jobName;
+ private boolean isDeletingAllViews;
+ private JobPriority jobPriority;
+ private boolean isForeground;
+ private int splitSize;
+ private Job job;
+
+ public void parseArgs(String[] args) {
+ CommandLine cmdLine;
+ try {
+ cmdLine = parseOptions(args);
+ } catch (IllegalStateException e) {
+ printHelpAndExit(e.getMessage(), getOptions());
+ throw e;
+ }
+
+ if (getConf() == null) {
+ setConf(HBaseConfiguration.create());
+ }
+
+ if (cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt())) {
+ this.isDeletingAllViews = true;
+ } else if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())) {
+ baseTableName = cmdLine.getOptionValue(TABLE_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ } else if (cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ viewName = cmdLine.getOptionValue(VIEW_NAME_OPTION.getOpt());
+ this.isDeletingAllViews = false;
+ }
+
+ if (cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ tenantId = cmdLine.getOptionValue((TENANT_ID_OPTION.getOpt()));
+ }
+
+ jobPriority = getJobPriority(cmdLine);
+ if (cmdLine.hasOption(SPLIT_SIZE_OPTION.getOpt())) {
+ splitSize = Integer.valueOf(cmdLine.getOptionValue(SPLIT_SIZE_OPTION.getOpt()));
+ } else {
+ splitSize = DEFAULT_MAPPER_SPLIT_SIZE;
+ }
+ isForeground = cmdLine.hasOption(RUN_FOREGROUND_OPTION.getOpt());
+ }
+
+ public String getJobPriority() {
+ return this.jobPriority.toString();
+ }
+
+ private JobPriority getJobPriority(CommandLine cmdLine) {
+ String jobPriorityOption = cmdLine.getOptionValue(JOB_PRIORITY_OPTION.getOpt());
+ if (jobPriorityOption == null) {
+ return JobPriority.NORMAL;
+ }
+
+ switch (jobPriorityOption) {
+ case "0" : return JobPriority.VERY_HIGH;
+ case "1" : return JobPriority.HIGH;
+ case "2" : return JobPriority.NORMAL;
+ case "3" : return JobPriority.LOW;
+ case "4" : return JobPriority.VERY_LOW;
+ default:
+ return JobPriority.NORMAL;
+ }
+ }
+
+ public boolean isDeletingAllViews() {
+ return this.isDeletingAllViews;
+ }
+
+ public String getTenantId() {
+ return this.tenantId;
+ }
+
+ public String getBaseTableName() {
+ return this.baseTableName;
+ }
+
+ public String getViewName() {
+ return this.viewName;
+ }
+
+ public int getSplitSize() {
+ return this.splitSize;
+ }
+
+ public CommandLine parseOptions(String[] args) {
+ final Options options = getOptions();
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmdLine = null;
+ try {
+ cmdLine = parser.parse(options, args);
+ } catch (ParseException e) {
+ printHelpAndExit("Error parsing command line options: " + e.getMessage(), options);
+ }
+
+ if (!cmdLine.hasOption(DELETE_ALL_VIEW_OPTION.getOpt()) && !cmdLine.hasOption(TABLE_NAME_OPTION.getOpt())
+ && !cmdLine.hasOption(VIEW_NAME_OPTION.getOpt()) && !cmdLine.hasOption(TENANT_ID_OPTION.getOpt())) {
+ throw new IllegalStateException("No deletion job is specified, " +
+ "please indicate deletion job for ALL/TABLE/VIEW/TENANT level");
+ }
+
+ if (cmdLine.hasOption(TABLE_NAME_OPTION.getOpt()) && cmdLine.hasOption(VIEW_NAME_OPTION.getOpt())) {
+ throw new IllegalStateException("Table and View name options cannot be set at the same time");
+ }
+
+ if (cmdLine.hasOption(HELP_OPTION.getOpt())) {
+ printHelpAndExit(options, 0);
+ }
+
+ this.jobPriority = getJobPriority(cmdLine);
+
+ return cmdLine;
+ }
+
+ private Options getOptions() {
+ final Options options = new Options();
+ options.addOption(DELETE_ALL_VIEW_OPTION);
+ options.addOption(TABLE_NAME_OPTION);
+ options.addOption(VIEW_NAME_OPTION);
+ options.addOption(TENANT_ID_OPTION);
+ options.addOption(HELP_OPTION);
+ options.addOption(JOB_PRIORITY_OPTION);
+ options.addOption(RUN_FOREGROUND_OPTION);
+ options.addOption(SPLIT_SIZE_OPTION);
+
+ return options;
+ }
+
+ private void printHelpAndExit(String errorMessage, Options options) {
+ System.err.println(errorMessage);
+ printHelpAndExit(options, 1);
+ }
+
+ private void printHelpAndExit(Options options, int exitCode) {
+ HelpFormatter formatter = new HelpFormatter();
+ formatter.printHelp("help", options);
+ System.exit(exitCode);
+ }
+
+ public void setJobName(String jobName) {
+ this.jobName = jobName;
+ }
+
+ public String getJobName() {
+ if (this.jobName == null) {
+ String jobName;
+ if (this.isDeletingAllViews) {
+ jobName = RUNNING_FOR_DELETE_ALL_VIEWS_STRING;
+ } else if (this.getBaseTableName() != null) {
+ jobName = this.getBaseTableName();
+ } else if (this.getViewName() != null) {
+ jobName = this.getViewName();
+ } else {
+ jobName = this.tenantId;
+ }
+ this.jobName = "ViewTTLTool-" + jobName + "-";
+ }
+
+ return this.jobName;
+ }
+
+ public void setViewTTLJobInputConfig(Configuration configuration) {
+ if (this.isDeletingAllViews) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_ALL_VIEWS,
+ RUNNING_FOR_DELETE_ALL_VIEWS_STRING);
+ } else if (this.getBaseTableName() != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_PER_TABLE,
+ this.baseTableName);
+ } else if (this.getViewName() != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_VIEW_TTL_DELETE_JOB_PER_VIEW,
+ this.viewName);
+ }
+
+ if (this.tenantId != null) {
+ configuration.set(PhoenixConfigurationUtil.MAPREDUCE_TENANT_ID, this.tenantId);
+ }
+ }
+
+ public void configureJob() throws Exception {
+ this.job = Job.getInstance(getConf(),getJobName() + System.currentTimeMillis());
+ PhoenixMapReduceUtil.setInput(job, this);
+
+ job.setJarByClass(ViewTtlTool.class);
+ job.setMapperClass(ViewTTLDeleteJobMapper.class);
+ job.setMapOutputKeyClass(NullWritable.class);
+ job.setMapOutputValueClass(NullWritable.class);
+ job.setOutputFormatClass(NullOutputFormat.class);
+ job.setNumReduceTasks(0);
+ job.setPriority(this.jobPriority);
+
+ TableMapReduceUtil.addDependencyJars(job);
+ LOGGER.info("ViewTTLTool is running for " + job.getJobName());
+ }
+
+ public int runJob() {
+ try {
+ if (isForeground) {
+ LOGGER.info("Running ViewTTLTool in Foreground. " +
+ "Runs full table scans. This may take a long time!");
+ return (job.waitForCompletion(true)) ? 0 : 1;
+ } else {
+ LOGGER.info("Running ViewTTLTool in Background - Submit async and exit");
+ job.submit();
+ return 0;
+ }
+ } catch (Exception e) {
+ LOGGER.error("Caught exception " + e + " trying to run ViewTTLTool.");
+ return 1;
+ }
+ }
+
+ public static class ViewTTLDeleteJobMapper
Review comment:
why not create a different class fo this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services