You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/05/31 02:55:49 UTC
[GitHub] incubator-hawq pull request: HAWQ-768. Refactor c++ code for src/t...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/683
HAWQ-768. Refactor c++ code for src/test/feature/lib.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-768
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/683.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #683
----
commit 2777cda6cf40d373c8a968c49b33c23902a81924
Author: xunzhang <xu...@gmail.com>
Date: 2016-05-31T02:45:51Z
HAWQ-768. Refactor string_utl, xml_parser impl of src/test/feature/lib.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-768. Refactor c++ code for src/test/featur...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on the pull request:
https://github.com/apache/incubator-hawq/pull/683
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #683: HAWQ-768. Refactor c++ code for src/test/feature/...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/683
Merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: [WIP]HAWQ-768. Refactor c++ code for ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/683#issuecomment-222634161
@wengyanqing I try to run `feature-test` together with `valgrind` but got some lost and leak. I am not sure what's the problem(maybe gtest, mac, valgrind itself), have you ever tried that in running `feature-test`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #683: HAWQ-768. Refactor c++ code for src/test/f...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/683
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #683: HAWQ-768. Refactor c++ code for src/test/feature/...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/683
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #683: HAWQ-768. Refactor c++ code for src/test/feature/...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/683
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: [WIP]HAWQ-768. Refactor c++ code for ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/683#issuecomment-222633520
cc @zhangh43 plz review the first commit, @wengyanqing @ztao1987 plz review the second commit, @ictmalili plz review the third commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---